1846902 - Some APZ cleanups related to async transforms

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

A few things I spotted while doing code reading for bug 1827330 that I'd like to clean up.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1846902 - Remove mentions of 'transient' and 'nontransient' async transforms in the comment above APZCTreeManager::GetScreenToApzcTransform(). r=dlrobertson

The "nontransient async transform" has been removed a long time ago,
in bug 1076241.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1846902 - Rename AsyncTransformConsumer::eForHitTesting to eForEventHandling. r=dlrobertson

We don't perform hit testing in APZ any more (that's done in WebRender).
The use cases for which we want to use the most up to date async transform
that reflects all previously received input events even if we haven't
composited their effects yet, are more accurately summarized as "event
handling".

Depends on D185256

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1846902 - Move AsyncTransformConsumer from AsyncPanZoomController to namespace scope. r=dlrobertson

Make it an enum class to avoid placing the enumerators themselves into
namespace scope.

This allows the next patch to use the enum in APZCTreeManager.h,
where only the forward declaration of AsyncPanZoomController is visible.

For convenience, add forwarding constants to AsyncPanZoomController.

Depends on D185257

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1846902 - Propagate an AsyncTransformConsumer parameter into SidesStuckToRootContent(). r=dlrobertson

The implementation was unconditionally passing eForEventHandling to
GetCurrentAsyncTransform(), but one of the call sites was actually
used for compositing.

Depends on D185258

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1846902 - Inline GetCurrentAsyncTransformWithOverscroll() into GetAsyncTransformForInputTransformation(). r=dlrobertson

It was its only caller.

Depends on D185259

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72a0f8d8f122
Remove mentions of 'transient' and 'nontransient' async transforms in the comment above APZCTreeManager::GetScreenToApzcTransform(). r=dlrobertson
https://hg.mozilla.org/integration/autoland/rev/4f01e3e561f6
Rename AsyncTransformConsumer::eForHitTesting to eForEventHandling. r=dlrobertson
https://hg.mozilla.org/integration/autoland/rev/a05b5784e815
Move AsyncTransformConsumer from AsyncPanZoomController to namespace scope. r=dlrobertson
https://hg.mozilla.org/integration/autoland/rev/2e239b493409
Propagate an AsyncTransformConsumer parameter into SidesStuckToRootContent(). r=dlrobertson
https://hg.mozilla.org/integration/autoland/rev/7bccadd8e28c
Inline GetCurrentAsyncTransformWithOverscroll() into GetAsyncTransformForInputTransformation(). r=dlrobertson

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/72a0f8d8f122
https://hg.mozilla.org/mozilla-central/rev/4f01e3e561f6
https://hg.mozilla.org/mozilla-central/rev/a05b5784e815
https://hg.mozilla.org/mozilla-central/rev/2e239b493409
https://hg.mozilla.org/mozilla-central/rev/7bccadd8e28c