184728 - digest: Use no-DB init and add new SHA digests

Status: NEW

(NSS :: Tools, enhancement, P3)

Description

[Terry Hayes]

Improve the digest utility by adding a -d <directory> option to be consistant 
with other tools.  In addition, make changes necessary to support the new SHA 
digests when they are implemented in NSS libraries.

(SHA changes are already partly done in NSS, which causes errors in the 
current digest utility when the command usage is displayed.  This patch 
recognizes the new digests, but will fail to generate results until NSS 
changes are complete.)

Comment 1

[Terry Hayes]

Attachment: Proposed patch for the digest tool

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

In the patch, I see this:

+    optstate = PL_CreateOptState(argc, argv, "t:i:o:d:");
     while ((status = PL_GetNextOpt(optstate)) == PL_OPT_OK) {
        switch (optstate->option) {
          case '?':
            Usage(progName);
            break;

IINM, the case '?' is dead code since '?' is not part of the options string.
AFAIK, PK_CreateOptState doesn't special-case '?', so if it's not in the 
options string, it will not be treated as an option.  


The while loop that handles options should probably be followed with the 
following code:

    if (status == PL_OPT_BAD) {
      Usage(progname);
    }
    PL_DestroyOptState(optstate)

These issues with command parsing are common to numerous NSS commands.

Comment 3

[Terry Hayes]

I'm changing this request.  Rather than add a new option to specify the 
directory for database files, I'm going to use the NSS_NoDB_Init method.  This 
means that no databases are required to use this tool.

The only negative of this approach is that there is no way to add other crypto 
tokens that may be able to perform the digest functions (no secmod.db).

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Terry, did you produce a revised patch?