Open Bug 1847314 Opened 10 months ago Updated 9 months ago

`./mach browsertime --clobber --setup --install-vismet-reqs` fails with an error

Categories

(Testing :: Raptor, defect, P3)

Default
defect

Tracking

(Not tracked)

People

(Reporter: gregtatum, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxp])

The error is:

TypeError: '<' not supported between instances of 'StrictVersion' and 'StrictVersion'

  File "/Users/greg/dev/frontend/tools/browsertime/mach_commands.py", line 670, in browsertime
    return setup_browsertime(
  File "/Users/greg/dev/frontend/tools/browsertime/mach_commands.py", line 347, in setup_browsertime
    node_dir = os.path.dirname(node_path(command_context))
  File "/Users/greg/dev/frontend/tools/browsertime/mach_commands.py", line 100, in node_path
    node_exe = find_node_executable(min_version=StrictVersion(MIN_NODE_VERSION))
  File "/Users/greg/dev/frontend/python/mozbuild/mozbuild/nodeutil.py", line 97, in find_node_executable
    return find_executable("node", min_version)
  File "/Users/greg/dev/frontend/python/mozbuild/mozbuild/nodeutil.py", line 123, in find_executable
    if version < min_version:

The full command output is:

➤ ./mach browsertime --clobber --setup --install-vismet-reqs

 0:00.10 [INFO] This command should be used for browsertime setup only.
If you are looking to run performance tests on your patch, use `./mach raptor --browsertime` instead.

You can get visual-metrics by using the --browsertime-video and --browsertime-visualmetrics. Here is a sample command for raptor-browsertime:
	`./mach raptor --browsertime -t amazon --browsertime-video --browsertime-visualmetrics`

See this wiki page for more information if needed: https://wiki.mozilla.org/TestEngineering/Performance/Raptor/Browsertime


 0:05.13 Using artifact from local cache: /Users/greg/.mozbuild/cache/browsertime/bfe641b7cf8b5df5-ffmpeg-macos.zip
 0:05.13 Unpacking temporary location /Users/greg/.mozbuild/cache/browsertime/bfe641b7cf8b5df5-ffmpeg-macos.zip
 0:05.87 Installing python requirements
/Users/greg/.pyenv/versions/3.10.12/lib/python3.10/site-packages/_distutils_hack/__init__.py:33: UserWarning: Setuptools is replacing distutils.
  warnings.warn("Setuptools is replacing distutils.")
 0:06.09 Installing browsertime node module from /Users/greg/dev/frontend/tools/browsertime/package.json
Error running mach:

    mach browsertime --clobber --setup --install-vismet-reqs

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file browsertime`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: '<' not supported between instances of 'StrictVersion' and 'StrictVersion'

  File "/Users/greg/dev/frontend/tools/browsertime/mach_commands.py", line 670, in browsertime
    return setup_browsertime(
  File "/Users/greg/dev/frontend/tools/browsertime/mach_commands.py", line 347, in setup_browsertime
    node_dir = os.path.dirname(node_path(command_context))
  File "/Users/greg/dev/frontend/tools/browsertime/mach_commands.py", line 100, in node_path
    node_exe = find_node_executable(min_version=StrictVersion(MIN_NODE_VERSION))
  File "/Users/greg/dev/frontend/python/mozbuild/mozbuild/nodeutil.py", line 97, in find_node_executable
    return find_executable("node", min_version)
  File "/Users/greg/dev/frontend/python/mozbuild/mozbuild/nodeutil.py", line 123, in find_executable
    if version < min_version:

Sentry event ID: b3891de28ce148f59c1910a37c848c62

Thanks for filing this, I am able to reproduce it locally as well.

However I don't believe you need this step for running raptor tests locally

e.g. https://firefox-source-docs.mozilla.org/testing/perfdocs/browsertime.html#mach-browsertime-setup

Note that if you are running Raptor-Browsertime then it will get installed automatically and also update itself. Otherwise, you can run:
./mach browsertime --clobber --setup --install-vismet-reqs

Since you were already running raptor-browsertime before (according to the other bugs you filed) you should be fine and not need this step.

Eitherway we should look into this error.

Blocks: dev-pain
Whiteboard: [fxp]
Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.