1847319 - Text rendering issues in Firefox 115 on Android

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[james.haggerty]

I have the same issue as #1843749 with an Adreno 308 and driver V@0502.0. Suspect that the fix there should just includes all driver versions for the 308.

I haven't used Bugzilla before, so I'm not sure of the right way to report this, and I didn't have permissions to comment on the existing issue as it was closed, so sorry if I've done the wrong thing.

Comment 1

[james.haggerty]

(Phone is a Cat S22 Flip with a Snapdragon 215)

Comment 2

[Jamie Nicol [:jnicol]]

Attachment: Bug 1847319 - Block QCOM_tiled_rendering on all driver version on Adreno 308 GPUs. r?#gfx-reviewers

In bug 1843749 we received reports of QCOM_tiled_rendering causing
glitches on Adreno 308 GPUs. As using this extension is a performance
win, especially on less powerful GPUs such as the Adreno 308, we
decided to block it only on the driver versions which we knew were
broken: V@331 and V@415.

However, we have now received a report that it is additionally broken
on version V@0502. As it now seems likely the bug affects all driver
versions, or at least more than originally hoped, this patch blocks
the extension on the Adreno 308 regardless of driver version.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4297ef6efd09
Block QCOM_tiled_rendering on all driver version on Adreno 308 GPUs. r=gfx-reviewers,lsalzman

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1828248

Comment 5

[Chris Peterson [:cpeterson]]

James, thanks for reporting this bug! It's not possible for us to test every device or driver version, so the details you shared are a huge help.

We'll probably want to uplift this fix from Nightly 118 to Beta 117 or even the 116.0.2 dot release scheduled for 2023-08-14 next week.

Comment 6

[Jamie Nicol [:jnicol]]

Comment on attachment 9347621 [details]
Bug 1847319 - Block QCOM_tiled_rendering on all driver version on Adreno 308 GPUs. r?#gfx-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Rendering glitches for users with Adreno 308 GPUs with driver version not fixed in the previous patch
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Disables an optimisation for a specific GPU. We don't use the optimisation on most devices anyway, and didn't on these devices until recently, so we are moving these devices to the better tested path.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Jamie Nicol [:jnicol]]

Might as well be a ride-along for the dot release IMO, it is as low risk as they come

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4297ef6efd09

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9347621 [details]
Bug 1847319 - Block QCOM_tiled_rendering on all driver version on Adreno 308 GPUs. r?#gfx-reviewers

Approved for 117.0b5

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2658ff909fe4

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9347621 [details]
Bug 1847319 - Block QCOM_tiled_rendering on all driver version on Adreno 308 GPUs. r?#gfx-reviewers

Approved for the 116.0.3 dot release

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/51f0706393fd