1847576 - Cannot add Remote Content exceptions. Error "nsIPermissionManager is not defined"

Status: RESOLVED FIXED

(Thunderbird :: Security, defect)

Description

[Daron Brewood]

Attachment: CleanShot 2023-08-06 at [e-mail]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36

Steps to reproduce:

Looked to configure the remote content configuration system via settings

Actual results:

It doesn't allow you to add websites or email addresses within the configuration system itself, only via the options in the message. The 'Allow' button does nothing....

Expected results:

Expected to be able to add the designated site or email address.

Comment 1

[Daron Brewood]

In the error console:

Uncaught ReferenceError: nsIPermissionManager is not defined
    oncommand chrome://messenger/content/preferences/permissions.xhtml:1 permissions.xhtml:1:1

Comment 2

[Andre Klapper]

You can enter websites. You cannot enter email addresses.

Comment 3

[Daron Brewood]

I've just tried it again now, it doesn't allow me to enter a website.

Comment 4

[Daron Brewood]

Plus the dialog description says you should be able to enter email addresses. You can enter either via the message controls

Comment 5

[betterbird.project+8]

No bug - Remove some pointless abbreviations of Ci members. rs=me
https://hg.mozilla.org/comm-central/rev/04ec8db91ce39c64f0f50b112c9ec02cad5cae41#l3.12

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1847576-fix-permission-manager.patch

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1847576 - Fix and test broken buttons in remote content/cookie dialogs. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f0c6e4e10ade
Fix and test broken buttons in remote content/cookie dialogs. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9347782 [details]
Bug 1847576 - Fix and test broken buttons in remote content/cookie dialogs. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: remote content and cookie dialogs in settings broken
Testing completed (on c-c, etc.): landed yesterday, with a test to prove it works
Risk to taking this patch (and alternatives if risky): no

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9347782 [details]
Bug 1847576 - Fix and test broken buttons in remote content/cookie dialogs. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 117.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/df025d983191

Comment 11

[Geoff Lankow (:darktrojan)]

Comment on attachment 9347782 [details]
Bug 1847576 - Fix and test broken buttons in remote content/cookie dialogs. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: remote content and cookie dialogs in settings broken
Testing completed (on c-c, etc.): landed yesterday, with a test to prove it works
Risk to taking this patch (and alternatives if risky): no

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9347782 [details]
Bug 1847576 - Fix and test broken buttons in remote content/cookie dialogs. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 115.2.0:
https://hg.mozilla.org/releases/comm-esr115/rev/f5bd162cf7e0