1847680 - Search messages dialog doesn't clean itself up properly, breaks code coverage

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Geoff Lankow (:darktrojan)]

I've been looking into why some of the code coverage results show some code as not covered when I know it is. One test in particular seems to hide coverage data from earlier tests.

Long story short: the Search Messages dialog has an nsIMsgWindow object that isn't cleaned up properly, somehow managing to poison the coverage data in files that dialog shares with other windows.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1847680 - Fix leak of nsIMsgWindow object from various dialogs. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a3a6f8bd26b6
Fix leak of nsIMsgWindow object from various dialogs. r=mkmelin

Comment 3

[Wayne Mery (:wsmwk)]

Good for beta?

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9347796 [details]
Bug 1847680 - Fix leak of nsIMsgWindow object from various dialogs. r=#thunderbird-reviewers

[Triage Comment]
APproved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 117.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/2afdba59e0af

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9347796 [details]
Bug 1847680 - Fix leak of nsIMsgWindow object from various dialogs. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.1:
https://hg.mozilla.org/releases/comm-esr115/rev/4ee8edddf6a3