1847787 - Pocket newtab sponsored topsite enabled by default

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1847787 - Pocket newtab sponsored topsites enabled by default

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7544c8f9eea7
Pocket newtab sponsored topsites enabled by default r=nanj

Comment 3

[Cristian Tuns]

Backed out for causing marionette crashes with @ mozilla::net::nsHttpChannel::OnStartRequest

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | Attempting to connect to non-local address! opener is [unknown], uri is [https://spocs.getpocket.com/spocs] [@ mozilla::net::nsHttpChannel::OnStartRequest] | marionette.py

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/181edf360c56
Pocket newtab sponsored topsites enabled by default r=nanj,webdriver-reviewers,whimboo

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_newtab_ping.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a4d47be53b99d0b267deb3ee478b18b44848b7a4
Log link: https://treeherder.mozilla.org/logviewer?job_id=426071149&repo=autoland&lineNumber=12958

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5af04f9a95e0
Pocket newtab sponsored topsites enabled by default r=nanj,webdriver-reviewers,whimboo

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5af04f9a95e0

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 9347974 [details]
Bug 1847787 - Pocket newtab sponsored topsites enabled by default

Beta/Release Uplift Approval Request

• User impact if declined: Revenue impact
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: We don't really have sponsored Pocket content for this currently, so even if it's turned on, you won't see something.

So let's just do regression testing on topsites, specifically check that existing sponsored topsites still show.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a basic code change, and a pref flip. The rest of the changes were to tests.

It has also been turned on for various experiments and tested that way.

• String changes made/needed: None
• Is Android affected?: No

Comment 9

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9347974 [details]
Bug 1847787 - Pocket newtab sponsored topsites enabled by default

Approved for 117.0b9.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5512d728e4ed

Comment 12

[Carmen Fat [:cfat] - Ecosystem QA]

We verified this issue on the latest Firefox Nightly 118.0a1 (Build ID: 20230816215210) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64. Since the Pocket tile is not available for testing, we performed regression testing on the existing sponsored and non-sponsored topsites. The following scenarios were covered across all 3 platforms:

1. Verified that the Sponsored Tiles are displayed on certain regions (US, FR, ES, and DE).
2. Verified that the Sponsored Tiles redirect to the correct page.
3. Verified that the impression/click pings are registered in the Browser Console.
4. Verified that the Sponsored Tiles cannot be moved to another position.
5. Verified each option from the Sponsored Tile menu (...).
6. Verified that the Sponsored Tiles can be dismissed.
7. Verified that the Sponsored Tiles are displayed if a New Window is opened.
8. Verified that if moving Non-Sponsored Tiles nothing is broken in the New Tab’s Page UI.

Comment 13

[Cosmin Muntean [:cmuntean], Ecosystem QA]

We verified this issue on the latest Firefox Beta 117.0b9 (Build ID: 20230817175856) on Windows 10 x64, macOS 13.1, and Linux Mint 21.1 Cinnamon 5.6.5. We performed regression testing on the existing sponsored and non-sponsored topsites. The following scenarios were covered across all 3 platforms:

1. Verified that the Sponsored Tiles are displayed on certain regions (UK, CA, IT, AU, US and DE).
2. Verified that the Sponsored Tiles redirect to the correct page.
3. Verified that the impression/click pings are registered in the Browser Console.
4. Verified that the Sponsored Tiles cannot be moved to another position.
5. Verified each option from the Sponsored Tile menu (...).
6. Verified that the Sponsored Tiles can be dismissed.
7. Verified that the Sponsored Tiles are displayed if a New Window is opened.
8. Verified that if moving Non-Sponsored Tiles nothing is broken in the New Tab’s Page UI.

Besides these scenarios, we have also performed exploratory testing and we haven't found any regressions.