18478 - [4.xP] base href ignored if in body

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[tpkec]

1. Go to www.pcpro.co.uk
2. Click on chat button on the toolbar.
Exprecting: registration page to be displayed in the main frame.
Actual result: registration page is diplayed in the toolbar frame.

Comment 1

[karnaze (gone)]

Reassigning to Eric.

Comment 2

[Matt Bissiri]

The reason that the registration page is appearing in the wrong frame is this:
http://www.pcpro.co.uk/toptoolbar.html has this tag inside the body:
<base target="midmiddle">
According to the html 4 spec, the base tag must be in the head, not the body.
Nav 4 allows the base tag in the body.

Comment 3

[Matt Bissiri]

Attachment: simplified testcase

Comment 4

[Matt Bissiri]

Attachment: patch adding AddBaseTagInfo() in HTMLContentSink::ProcessMAPTag()

Comment 5

[Eric Pollmann]

Thanks for the patch Matt, I'll try to get this in M13!

Comment 6

[Eric Pollmann]

Attachment: inner frame, used by test case 2

Comment 7

[Eric Pollmann]

Attachment: test case 2

Comment 8

[Eric Pollmann]

I just checked in Matt's fix.  Thanks Matt!

To verify the fix, view Test Case 2.  Click in the upper left hand corner of the
ant image.  You should see a page loaded in the bottom frame.  If so, the bug is
fixed.  If instead the page is loaded in the top frame, the bug is not fixed.
Thanks!

Comment 9

[Chris Petersen]

Fixed in the Jan 31 build (2000013111).