1847815 - Decouple the use of import wizard variants in embedded and non-embedded wizard

Status: VERIFIED FIXED

(Firefox :: Migration, enhancement, P3)

Description

[Ania]

User story
As a PM group, we would like to be able to control what import experience (variant 1 or expanded VS variant 2 or collapsed) users get when they access import from different entry points, so that we can offer optimal experience to users at different stages of their familiarity and trust in the product.

Acceptance criteria

1. Embedded wizard in about:welcome defaults to variant 1.
2. All other import entry points default to variant 2

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1847815 - Allow embedders of the migration-wizard to override the variant pref via an attribute. r?kpatenio!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba6f0c60d71d
Allow embedders of the migration-wizard to override the variant pref via an attribute. r=kpatenio

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ba6f0c60d71d

Comment 4

[Mimi Jung]

Comment on attachment 9348005 [details]
Bug 1847815 - Allow embedders of the migration-wizard to override the variant pref via an attribute. r?kpatenio!

Beta/Release Uplift Approval Request

• User impact if declined: Patch is required for 1847276 which is planned to also be uplifted.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please refer to test steps in 1847276
• List of other uplifts needed: Bug 1847276
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch allows passing in an attribute to about:welcome import component/screen to render a different layout. The logic to render the different layout happens in 1847276.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9348005 [details]
Bug 1847815 - Allow embedders of the migration-wizard to override the variant pref via an attribute. r?kpatenio!

Approved for 117.0b7.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6a43668bf0f8

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task using the steps provided in the Test Plan and I can confirm the following:

• The expanded variant of the "Embedded Import Wizard" Onboarding screen(all the options are visible and there is no "+" button) is displayed on the "about:welcome" page.
• All the elements from the Onboarding import screen are successfully rendered and the is no overlap if the browser is resized <800px.
• The non-expanded version (the options are collapsed and the "+" button is displayed) of the "Import Wizard" is displayed if the Import Data button from the "Import Browser Data" section of the "about:preferences#general" page is displayed.
• Client is redirected to the "about:preferences#general" page and the non-expanded version of the "Import Wizard" is displayed if the "Import From Another Browser..." option from the "File" browser menu is clicked.
• Client is redirected to the "about:preferences#general" page and the non-expanded version of the "Import Wizard" is displayed if the "Import Data from Another Browser..." option from the "Bookmarks" window is clicked.

Verified using the latest Firefox Beta 117.0b8 (Build ID: 20230815180041) and the latest Firefox Nightly 118.0a1 (Build ID: 20230816094547) installed on Windows 10 x64, macOS 13.4.1, and Linux Mint 21.1.