184784 - Add support for AIX 5.1 to security/coreconf

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Sonja Mirtitsch]

we need AIX 5.1 support for NSS 3.3.3

please see bug http://bugzilla.mozilla.org/show_bug.cgi?id=133753 for how it was
added on NSS 3.5
nspr seems to work fine http://bugzilla.mozilla.org/show_bug.cgi?id=184511

Comment 1

[Sonja Mirtitsch]

Attachment: makefile we got for 3.3.2 from a server team

Comment 2

[Wan-Teh Chang]

Comment on attachment 108988 [details]
makefile we got for 3.3.2 from a server team

I found that this file was constructed by collapsing
coreconf/AIX4.3.mk (that is, substituting the contents
of the included file coreconf/AIX.mk in place), with
the following two changes.

1. It added -lpthreads to MKSHLIB and OS_LIBS.	We should
find out from the source of this file whether this change
is really necessary and whether we should make the same
change to AIX4.3.mk.

>MKSHLIB         = $(LD) $(DSO_LDOPTS) -lsvld -L/usr/lpp/xlC/lib -lc -lm \
>		  -lpthreads
>
>OS_LIBS         += -L/usr/lpp/xlC/lib -lc -lm -lpthreads

2. It added the following from NSPR's config/AIX.mk, which
is not applicable to NSS and should be deleted.

>ifeq (,$(filter-out 5.1,$(OS_RELEASE)))
># On these OS revisions, gethostbyXXX() returns result in thread
># specific storage.
>ifeq ($(USE_PTHREADS),1)
>OS_CFLAGS       += -D_PR_HAVE_THREADSAFE_GETHOST
>endif
>endif

We should backport our own coreconf/AIX5.1.mk from the
trunk to the NSS_3_3_BRANCH and possibly make the first
change above (adding -lpthreads) if we confirm it is
useful.

Comment 3

[Wan-Teh Chang]

Attachment: coreconf/AIX5.1.mk backported from the trunk to NSS_3_3_BRANCH

The only open issue is whether -lpthreads should be
added to MKSHLIB and OS_LIBS.

Comment 4

[Sonja Mirtitsch]

> 1. It added -lpthreads to MKSHLIB and OS_LIBS.	We should
> find out from the source of this file whether this change
> is really necessary and whether we should make the same
> change to AIX4.3.mk.

change is not really ncessary

Comment 5

[Wan-Teh Chang]

I added the AIX5.1.mk I proposed to the NSS_3_3_BRANCH.

Comment 6

[Sonja Mirtitsch]

works now.