1847862 - pre-calculate hash for WebIDLNameTableEntry

Status: RESOLVED DUPLICATE of bug 1850344

(Core :: DOM: Bindings (WebIDL), task, P3)

Description

[Tooru Fujisawa [:arai]]

WebIDLNameTableEntry entry is used for creating atoms.
the string hash is calculated inside the API, but the hash is known at compile time and bindgen can generate mozilla::HashStringKnownLength call for it.

https://searchfox.org/mozilla-central/rev/0058dbdd1c2eb9164e195082d18f3a657f291824/dom/bindings/WebIDLGlobalNameHash.cpp#181-183,193-194

bool WebIDLGlobalNameHash::GetNames(JSContext* aCx, JS::Handle<JSObject*> aObj,
                                    NameType aNameType,
                                    JS::MutableHandleVector<jsid> aNames) {
...
      JSString* str = JS_AtomizeStringN(aCx, BindingName(entry.mNameOffset),
                                        entry.mNameLength);

https://searchfox.org/mozilla-central/rev/0058dbdd1c2eb9164e195082d18f3a657f291824/dom/bindings/WebIDLGlobalNameHash.h#24,30-31

struct WebIDLNameTableEntry {
...
  BindingNamesOffset mNameOffset;
  uint16_t mNameLength;

https://searchfox.org/mozilla-central/source/__GENERATED__/__linux64__/dom/bindings/RegisterBindings.cpp#699-702

const WebIDLNameTableEntry WebIDLGlobalNameHash::sEntries[] = {
  {
    /* mNameOffset */ BindingNamesOffset::Plugin,
    /* mNameLength */ 6,

Comment 1

[Tooru Fujisawa [:arai]]

this might become unnecessary if we can extend the well-known atoms with gecko atoms in bug 1848278.

Comment 2

[Tooru Fujisawa [:arai]]

This will be handled as a part of bug 1850344, by replacing the atomization code with extended-known atom.