1847956 - The "Add-on is not supported" snackbar is displayed overlapping the toolbar in the "Bottom" toolbar position

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, defect)

Description

[Delia Pop (Android QA)]

Attachment: Snackbar_overlappingToolbar.png

Preconditions

1. On mobile, make sure to have the developer options activated by going into Firefox' settings > About Firefox > Triple tap on Firefox logo.
2. On mobile, go to Settings > Customize > Toolbar and set the toolbar to "Bottom".
3. On Desktop, go to "https://addons.mozilla.org/" and log in to your account. Make sure to have a custom collection created, or create one by following these steps: https://support.mozilla.org/en-US/kb/how-use-collections-addonsmozillaorg# .

Steps to reproduce

1. On mobile, go to about:config and make sure the extensions.webapi.enabled pref is set to "true".
2. Open addons.mozilla.org in a new tab.
3. Select an add-on which is not already included in the custom collection from preconditions, and attempt to install the add-on.
4. Observe the snackbar displayed at the bottom of the page.

Expected behavior

The "Add-on is not supported" snackbar should be displayed above the toolbar.

Actual behavior

The "Add-on is not supported" snackbar is displayed overlapping the toolbar.

Device information

• Firefox version: Nightly 118.0a1 from 08/09
• Android device model: Samsung Galaxy A53 5G
• Android OS version: Android 13

Any additional information?

This issue was observed while testing the snackbar implementation in 1847179.

Comment 1

[William Durand [:willdurand]]

This isn't a regression or not a regression caused by Bug 1847179 at least. It looks like we've always displayed these add-on snackbars on top of the toolbar, which seems to not be the case for other non-extensions-related snackbars.

:amejia what do you think?

Comment 2

[Arturo Mejia [:amejia]]

Sorry, it was my mistake, I passed the wrong to the snackBar, I put a patch which will address the issue https://github.com/mozilla-mobile/firefox-android/pull/3197

Comment 3

[Arturo Mejia [:amejia]]

Attachment: Bug 1847956 - Show snackBars on top of the toolbar.

Comment 4

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/1d4c6069e48ae18c431745719e649b7f063b5233
[main] Bug 1847956 - Show snackBars on top of the toolbar.

Comment 5

[Delia Pop (Android QA)]

Attachment: Add-ons_Snackbar_AboveToolbar.png

Verified as fixed in latest Nightly 118.0a1 from 08/10 with Samsung Galaxy A53 5G (Android 13). The "Add-on is not supported" snackbar is displayed above the toolbar.

Comment 6

[Arturo Mejia [:amejia]]

Thanks Delia for verifying!