Open Bug 1847987 Opened 2 years ago Updated 2 years ago

Landing a commit with DONTBUILD after the first line should NOT trigger a build

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Type:
defect

Tracking

(Not tracked)

People

(Reporter: freaktechnik, Unassigned)

Details

STR:

  • Create a commit that has DONTBUILD in it's second or later lines of the commit message

Actual result:
No builds are triggered.

Expected result:
Builds are triggered, only a DONTBUILD in the first line stops builds.

Summary: Landing a commit with DONTBUILD outside the first line should still trigger a build → Landing a commit with DONTBUILD after the first line should still trigger a build

Looking around at other projects and stuff, there's precedent for scanning the entire commit message for these magic words, even if it is non-intuitive.

I've started a discussion here to see how others feel about this.

Personally, I think it makes more sense to only check the first line. That's the behavior implied by tools such as Lando and even the Treescript scriptworker. I am hesitating to change this for comm_taskgraph only because it deviates from what other repos will do and that will lead to more confusion.

Summary: Landing a commit with DONTBUILD after the first line should still trigger a build → Landing a commit with DONTBUILD after the first line should NOT trigger a build
You need to log in before you can comment on or make changes to this bug.