Closed Bug 1848089 Opened 2 years ago Closed 1 year ago

ebook pages are rendered with noisy grid lines in some ebook stores on Android

Categories

(Core :: Graphics: Canvas2D, defect, P2)

defect

Tracking

()

RESOLVED FIXED
118 Branch

People

(Reporter: masayuki, Unassigned)

References

Details

Attachments

(1 file)

Attached image Loaded image on Android

In DMM books, load an sample of a book, e.g., https://book.dmm.com/tachiyomi/?cid=FRNfXRNVFW1RAQxaCgNWQhINU0UAClEBVE5EDl0VClcHDl9SSkIAUVAMSFdeX1sGTRFEV15KDU0LDVk5VAlQDVQ_&lin=1&sd=0

Then, you could see grid lines in the page image like the attachment.

I cannot reproduce this bug on Windows nor Linux, but I can reproduce this bug on Galaxy Tab S8+ and Pixel 7a.

The script of DMM books seems retrieve blocks of split images and renders the "tiles" into a <canvas> element. See drawResizeImage_ in viewer_image_2.0.15_2023-01-19.js.

I see same symptom in DLSite (only after buying books), Melonbooks (same), Bookwalker.

Once the grid line appears in the image, changing the canvas size from the Inspector does not change anything. So I think that the noise appears at setting the image.

Of course, I cannot reproduce this bug in Chrome for Android.

This is not a recent regression, IIRC, this started several months ago. According to the JS file name in comment 0, it may appear with the update of the JS code (it claims that it's 19 Jan version).

Blocks: gfx-triage

We can double-check the shape of this page via https://github.com/kdashg/canvas-rr .
But this looks like the other seam issues we've been seeing.

See Also: → 1847162, 1847166
Severity: -- → S3
Priority: -- → P2

Any guesses on these seams, Lee?

Flags: needinfo?(lsalzman)

Oh, the direct link may not work.

  1. Go to https://book.dmm.com/product/4059334/b950ushes03586/
  2. Click the button labeled "試し読み"
No longer blocks: gfx-triage
Flags: needinfo?(lsalzman)

Odd, I cannot reproduce this bug anymore in all web sites which I listed up in comment 0. However, according to the file name in DMM, they do not update in their side. Did we change something?

Flags: needinfo?(lsalzman)

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #6)

Odd, I cannot reproduce this bug anymore in all web sites which I listed up in comment 0. However, according to the file name in DMM, they do not update in their side. Did we change something?

No idea. Can you try using moz-regression to narrow down which change might have fixed it?

It's possible bug 1845309 fixed it. You could try backing out that change (or try builds before and after that bug dat) first and see if it's the culprit?

Flags: needinfo?(lsalzman)

(In reply to Lee Salzman [:lsalzman] from comment #7)

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #6)

Odd, I cannot reproduce this bug anymore in all web sites which I listed up in comment 0. However, according to the file name in DMM, they do not update in their side. Did we change something?

No idea. Can you try using moz-regression to narrow down which change might have fixed it?

It's possible bug 1845309 fixed it. You could try backing out that change (or try builds before and after that bug dat) first and see if it's the culprit?

Could be that's it. The first good build is 2023-09-08 and the last bad build is 2023-09-07. mozregression GUI does not tell me the changeset range, the date matches with the fix of bug 1845309.

Status: NEW → RESOLVED
Closed: 1 year ago
Depends on: 1845309
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: