Closed Bug 1848119 Opened 2 years ago Closed 2 years ago

Remove unnecessary PageStyleActor#_expandRules

Categories

(DevTools :: Inspector, task)

task

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

It does look like this is not something we benefit from

This was added a long time ago (https://hg.mozilla.org/mozilla-central/rev/b14e58f0e3ab1ae9c1b5f7c59949e7063dc9817e) and it feels like this was needed because we were exposing a parentRule property on the form that was the actorID (https://hg.mozilla.org/mozilla-central/rev/b14e58f0e3ab1ae9c1b5f7c59949e7063dc9817e#l2.579)
So the client would be able to get the information it needed through that property and needed to have the parent rule front.
We don't have such property anymore on the front (removed in Bug 1752313), and so it looks like it should be safe to not retrieve the parent rules.

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/444aa2304c68 [devtools] Remove unnecessary PageStyleActor#_expandRules. r=devtools-reviewers,jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: