Closed Bug 1848167 Opened 7 months ago Closed 7 months ago

`getPromptText` method on GeckoView prompt should be awaited

Categories

(Remote Protocol :: Agent, task, P1)

task
Points:
2

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: Sasha, Assigned: Sasha)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m8][webdriver:relnote])

Attachments

(1 file)

As we can see here, getPromptText is actually async and should be awaited in the modal class. It might not cause too many problems now with Marionette since here we return from async method, but it doesn't work here for the logs. It also breaks things for BiDi prompt events.

Blocks: 1824224

Very good find! This could actually be the reason for various test failures on Android related to alerts. I'm going and mark those as being blocked by this bug.

Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:m8]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45b33d9f231a
[remote] Await `getPromptText` method from GeckoView prompt. r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Whiteboard: [webdriver:m8] → [webdriver:m8][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.