Closed
Bug 1848219
Opened 2 years ago
Closed 2 years ago
Update text styles of Review Quality Check UI after copy is finalized
Categories
(Firefox for Android Graveyard :: Shopping, task, P2)
Tracking
(firefox117 disabled, firefox118 disabled, firefox119 affected)
RESOLVED
WONTFIX
People
(Reporter: 007, Assigned: 007)
References
Details
(Whiteboard: [fxdroid] [fakespot-android-foxfooding])
Attachments
(2 files)
The copy within the Review Quality Check UI has some substring formatting that will require some composable annotated string styling once the copy is finalized.
As part of this ticket:
- Make sure the copy of the subcomponents is up-to-date.
- Ensure any appropriate styling is applied (high level styling like body 1, body 2, etc)
- Ensure any appropriate substring styling is applied (e.g. substring bolding/re-coloring).
For more context:
https://github.com/mozilla-mobile/firefox-android/pull/3147#discussion_r1288194788
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
Summary: Update text styles of Review quality explanation UI after copy is finalized → Update text styles of Review Quality Check UI after copy is finalized
Comment 1•2 years ago
|
||
Some differences in the "How we determine review quality" section compared to the Figma design:
- Missing bullet points for the higher and lower grade descriptions.
- Missing bold text for "letter grade", "adjusted rating", and "Highlights".
- Tapping the "Learn more about how Fakespot determines review quality" link doesn't do anything. I expected it would open a new page describing Fakespot's review analysis.
Updated•2 years ago
|
status-firefox119:
--- → affected
Whiteboard: [fxdroid] → [fxdroid] fakespot-android-mvp
Updated•2 years ago
|
status-firefox117:
--- → disabled
status-firefox118:
--- → disabled
Whiteboard: [fxdroid] fakespot-android-mvp → [fxdroid] [fakespot-android-foxfooding]
Comment 2•2 years ago
|
||
Changes for the review highlights card:
- The toolbar icon has changed from a shopping cart to a wallet.
- The section headers, like
Quality, should be bold text. - The review highlights should be in quotes.
Comment 3•2 years ago
|
||
Thanks Chris, the icon will be updated as part of Bug 1841600 and the review highlights quotes will be added with Bug 1852748.
The highlight section headers appear bold for me. Can you please confirm that it's still the case that they appear as in the screenshot you shared above?
| Assignee | ||
Updated•2 years ago
|
Assignee: nobody → nbond
| Assignee | ||
Updated•2 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 4•2 years ago
|
||
Closing this in favor of a new UX feedback meta
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
Updated•6 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•