1848262 - Thunderbird code coverage not recorded for resource:/// files

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Geoff Lankow (:darktrojan)]

The code coverage tools fail to map resource:/// modules back to the source code. I've worked out that it's because the default configuration is for Firefox which puts these files in dist/bin/browser, but we put the files in dist/bin. If this line is changed it works, but changing it would break Firefox code coverage. We could provide the right value here if we can work out whether Thunderbird or Firefox is being tested.

Comment 1

[Rob Lemley [:rjl]]

Cross your fingers... https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7e1abaaaa4f998ac6ec87f57e77eb3ca4c5f6375

Comment 2

[Geoff Lankow (:darktrojan)]

Looks like that does the trick. Nice one!

Comment 3

[Rob Lemley [:rjl]]

It's still not able to map a bunch of OpenPGP URLs, but that's probably another issue...

[task 2023-08-15T21:35:30.571Z] Error: No objdir path for chrome://openpgp/content/modules/keyRing.jsm.
[task 2023-08-15T21:35:30.571Z] Couldn't find source info for chrome://openpgp/content/modules/keyRing.jsm, removing record
[task 2023-08-15T21:35:30.571Z] Error: No objdir path for chrome://openpgp/content/modules/log.jsm.
[task 2023-08-15T21:35:30.571Z] Couldn't find source info for chrome://openpgp/content/modules/log.jsm, removing record
[task 2023-08-15T21:35:30.571Z] Error: No objdir path for chrome://openpgp/content/modules/mimeVerify.jsm.
[task 2023-08-15T21:35:30.571Z] Couldn't find source info for chrome://openpgp/content/modules/mimeVerify.jsm, removing record
[task 2023-08-15T21:35:30.571Z] Error: No objdir path for chrome://openpgp/content/modules/constants.jsm.
[task 2023-08-15T21:35:30.571Z] Couldn't find source info for chrome://openpgp/content/modules/constants.jsm, removing record
[task 2023-08-15T21:35:30.571Z] Error: No objdir path for chrome://openpgp/content/modules/RNP.jsm.
[task 2023-08-15T21:35:30.571Z] Couldn't find source info for chrome://openpgp/content/modules/RNP.jsm, removing record

I'll get patches submitted tomorrow.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1848262 - Set appdir from mozharness config when processing coverage files. r=jmaher

LCovFileRewriter uses "dist/bin/browser/" for the "appdir" parameter when no value
is passed. That's correct for Firefox, but Thunderbird needs to set appdir to
"dist/bin/".
In comm-central, "appdir" will be set in the Thunderbird mozharness unittest
config file so that appdir will be set appropriately. This allows for other
products to use code-coverage in the future as well.

Drive-by fix adds a \n when logging removed records for readability.

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1848262 - Set appdir in mozharness unittest config for code-coverage processing. r=darktrojan

Requires D186459 on mozilla-central.

Fixes code-coverage processing for resource:// URLs that were not being handled
previously due to appdir being set incorrectly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de32fb1defd2
Set appdir from mozharness config when processing coverage files. r=jmaher

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/de32fb1defd2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8d6e0f3f14d9
Set appdir in mozharness unittest config for code-coverage processing. r=darktrojan