1848406 - Stateful bounce detection for storage

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Paul Zühlcke [:pbz]]

+++ This bug was initially created as a clone of Bug #1839918 +++

In order to differentiate between stateful and non stateful bounces we need to hook into the cookies and storage implementations to populate BounceTrackingRecords Storage Access Set. This bug is for storages.

Storages include QuotaManager, Service workers, etc.

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1848406 - Detect stateful bounces for window associated storages. r=bvandersloot!

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1848406 - Extend stateful bounce tests. r=bvandersloot!

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1848406 - Enable requireStatefulBounces pref by default. r=bvandersloot!

Comment 4

[Paul Zühlcke [:pbz]]

Attachment: Bug 1848406 - Fix BounceTrackingState Init called more than once. r=bvandersloot!

Comment 5

[Paul Zühlcke [:pbz]]

Attachment: Bug 1848406 - Keep track of storage access in web workers. r=bvandersloot!

Comment 6

[Paul Zühlcke [:pbz]]

Attachment: Bug 1848406 - Split up cookies and storage bouncetracking tests. r=bvandersloot!

Comment 7

[Paul Zühlcke [:pbz]]

Attachment: Bug 1848406 - Add a stateful bounce test for nested web workers. r=asuth!

Comment 8

[Paul Zühlcke [:pbz]]

Running the patches on try I've discovered a shutdown hang: https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Cretry&revision=9b16f645907226d45ca9ac449d48f16981a830f0

Particularly the nested web worker test seems to be triggering it. :asuth suspects that it's related to Bug 1861785, which wouldn't be a bug in my implementation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31016e129e99
Detect stateful bounces for window associated storages. r=bvandersloot,asuth
https://hg.mozilla.org/integration/autoland/rev/940c5fd39d25
Extend stateful bounce tests. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/d75faab0301f
Enable requireStatefulBounces pref by default. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/80365ce68377
Fix BounceTrackingState Init called more than once. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/affbf180e519
Keep track of storage access in web workers. r=bvandersloot,asuth
https://hg.mozilla.org/integration/autoland/rev/6ce0fba99d02
Split up cookies and storage bouncetracking tests. r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/42ab5bd4b856
Add a stateful bounce test for nested web workers. r=asuth,bvandersloot

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing AddressSanitizer @ xpcom/base/nsISupportsImpl.cpp & bc failures @ toolkit/components/antitracking/bouncetrackingprotection/test/browser/<...>

Backout link: https://hg.mozilla.org/integration/autoland/rev/c80113ab4162029cc65655161b3466ba25380dea

Push with failures

Failure log -> SUMMARY: AddressSanitizer: access-violation /builds/worker/checkouts/gecko/xpcom/base/nsISupportsImpl.cpp:41 in nsAutoOwningThread::AssertCurrentThreadOwnsMe

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/bouncetrackingprotection/test/browser/browser_bouncetracking_stateful_cookies.js | Test timed out

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d63358e762de
Detect stateful bounces for window associated storages. r=bvandersloot,asuth
https://hg.mozilla.org/integration/autoland/rev/36b8e78cc27e
Extend stateful bounce tests. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/6808ec37fa93
Enable requireStatefulBounces pref by default. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/df982722bc0a
Fix BounceTrackingState Init called more than once. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/5ea32ea95f62
Keep track of storage access in web workers. r=bvandersloot,asuth
https://hg.mozilla.org/integration/autoland/rev/6a3ec1f62811
Split up cookies and storage bouncetracking tests. r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/40fdfaf3cc32
Add a stateful bounce test for nested web workers. r=asuth,bvandersloot

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f071b054a16
Detect stateful bounces for window associated storages. r=bvandersloot,asuth
https://hg.mozilla.org/integration/autoland/rev/ff789ea132bd
Extend stateful bounce tests. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/462b35b30c6a
Enable requireStatefulBounces pref by default. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/450b885176ac
Fix BounceTrackingState Init called more than once. r=bvandersloot,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/10b0efff98e2
Keep track of storage access in web workers. r=bvandersloot,asuth
https://hg.mozilla.org/integration/autoland/rev/3fd62a8397aa
Split up cookies and storage bouncetracking tests. r=bvandersloot
https://hg.mozilla.org/integration/autoland/rev/106c8d046414
Add a stateful bounce test for nested web workers. r=asuth,bvandersloot

Comment 13

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/1f071b054a16
https://hg.mozilla.org/mozilla-central/rev/ff789ea132bd
https://hg.mozilla.org/mozilla-central/rev/462b35b30c6a
https://hg.mozilla.org/mozilla-central/rev/450b885176ac
https://hg.mozilla.org/mozilla-central/rev/10b0efff98e2
https://hg.mozilla.org/mozilla-central/rev/3fd62a8397aa
https://hg.mozilla.org/mozilla-central/rev/106c8d046414