184847 - goindustry.com - Changing number of items to show does not change the web page, the next button doesn't work.

Status: RESOLVED INVALID

(Tech Evangelism Graveyard :: English US, defect)

Description

[Andrew Cervin-Lawry]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130

I am using Java(TM) Plug-in 1.4.1_01-b01.
I have enabled all cookies, scripts for browser/email etc.
I think it is a Javascript problem but I'm not sure.
Neither mozilla 1.0.1 or this one worked.

The pages work in Netscape 4.74 with Java(TM) Plug-in Blackdown-1.3.1-FCS.



Reproducible: Always

Steps to Reproduce:
1.Load page
2. Try changing # of items to display, or go to next page via the "next" link
3. no success

Actual Results:  
nothing

Expected Results:  
reloaded the page with more items displayed or gone to the next page.

Comment 1

[Phil Schwartau]

Confirming report using Mozilla trunk binary 20021204xx on WinNT.
I see these errors in Tools > Web Development > JavaScript Console:


--------------------------- Loading site:  ---------------------------
Error: layer has no properties
Source File: http://www.goindustry.com/includes/main.js?5.0.8
Line: 8

------------------------  Hitting "Next" link:  ----------------------
Error: g_oForm has no properties
Source File: http://www.goindustry.com/scripts/listfunctions.js?5.0.8
Line: 72

--------------------- Changing # of items to display:  --------------
Error: g_oForm has no properties
Source File: http://www.goindustry.com/scripts/listfunctions.js?5.0.8
Line: 26



These are due to coding errors at the site; I will explain more below.
Meanwhile, reassigning to Tech Evangelism so the site can be contacted.

Comment 2

[Phil Schwartau]

The first error listed above occurs during the init() function at the site.
That causes JavaScript processing to halt, leading to the subsequent errors:

var g_oForm;

function initAll() {
  init();      <<<-------------------------------- FATAL ERROR OCCURS HERE

  if (document.frmProductList) {
    g_oForm = document.frmProductList;  <<<------- THEREFORE THIS NEVER HAPPENS

           etc.
}


HERE IS THE INIT FUNCTION:

function init() {
  clipLayer(MM_findObj('layLogo'), 0, 0, 300, 85);
}


WHERE THEY USE:

function MM_findObj(n, d) { //v3.0
  var p,i,x;

  if(!d) d=document;

  if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document;
    n=n.substring(0,p);
  }

  if(!(x=d[n])&&d.all)
    x=d.all[n];

  for (i=0;!x&&i<d.forms.length;i++)
    x=d.forms[i][n];

  for(i=0;!x&&d.layers&&i<d.layers.length;i++)
    x=MM_findObj(n,d.layers[i].document);

  return x;
}


It is well-known that v3.0 of the Macromedia MM_findObj()
function does not work in W3C-compliant browsers like Mozilla.
The site needs to upgrade to v4.0 of Macromedia, which does work.


There may also be problems with the clipLayer() function:

function clipLayer(layer,clipleft,cliptop,clipright,clipbottom) {
  if(isMinNS4){
    layer.clip.left=clipleft;
    layer.clip.top=cliptop;
    layer.clip.right=clipright;
    layer.clip.bottom=clipbottom;
  }

  if(isMinIE4) {
         etc.
  }
}


Here is the browser-sniffing at the site:

var isMinNS4=(navigator.appName.indexOf("Netscape")>=0&&
             (parseFloat(sNavAppVer)>=4&parseFloat(sNavAppVer)<5))?1:0;
var isMinNS5=(navigator.appName.indexOf("Netscape")>=0&&
             parseFloat(sNavAppVer)>=5);
var isMinIE4=(document.all||isMinNS5)?1:0;

Comment 3

[Bob Clary [:bc] (inactive)]

tech evang june 2003 reorg

Comment 4

[sjw]

STR doesn't fit anymore.
[closeme]