Closed Bug 1848777 Opened 1 years ago Closed 1 years ago

[wpt-sync] Sync PR 41468 - [gardener] Revert "[A11y] Fix DCHECK related to missing parent"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox118 fixed)

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41468 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41468
Details from upstream follow.

Maksim Moskvitin <mmoskvitin@google.com> wrote:

[gardener] Revert "[A11y] Fix DCHECK related to missing parent"

This reverts commit 5165d20e7238073b0c3e36e83b2f156053459b8f.

Reason for revert: causes another check failure on Linux Tests (dbg), almost consistently. See crbug.com/1472987

Original change's description:

[A11y] Fix DCHECK related to missing parent

This fixes a DCHECK caused by an image's child being detached, and
that child object remaining in the cache but not attached to anything.
In the a11y tree, images can adopt children from elsewhere in the DOM via the usemap attribute, which results a lot of special cases in the engine.

Fixed: 1468593
Change-Id: I3d56349e8efc2e835790e4ff943aebf96de736e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4735234
Reviewed-by: Stefan Zager \<szager@chromium.org>
Auto-Submit: Aaron Leventhal \<aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal \<aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1183423}

Bug: 1468593, 1472987
Change-Id: I97f75f2f15520e4dfdc520b72b7080dd6e347e10
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780709
Owners-Override: Maksim Moskvitin \<mmoskvitin@google.com>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Maksim Moskvitin \<mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/main@{#1183564}

PR 41468 applied with additional changes from upstream: 43a6014a311144b7d26461347934abc055a97855
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d46342444fd6 [wpt PR 41468] - [gardener] Revert "[A11y] Fix DCHECK related to missing parent", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.