when storing login details in keychain, the wrong username field is remembered

RESOLVED FIXED in Camino0.9

Status

RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: richard, Assigned: mikepinkerton)

Tracking

unspecified
Camino0.9
PowerPC
Mac OS X

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021208 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021208 Chimera/0.6+

The example site I've given has a form for posting messages on the messageboard.
It has a subject field, a message field and an email address and password field.
When posting, Chimera recognises there is a password field on the forum and
offers to store the password. But rather than store the email address and
password it stores the subject and password. This means every time I goto post
messages the subject line is replaced with the subject of the message I was
replying to when the password was remembered.

This seems to be because Chimera is remembering the first field in the form as
the username rather than whatever field is before the password field.

So if subject is 1, main text is 2, email is 3 and password is 4, Chimera should
recognise, like IE does, that the username email is most likely to be field 3
(one field before password) than field 1.

Reproducible: Always

Steps to Reproduce:
1. Goto post new message or post reply.
2. Type in your message, email address and password.
3. Click submit and agree to remember password.
4. Go try post on another topic and see it fills in the subject line rather than
email field.

Actual Results:  
Subject field and password is remembered.

Expected Results:  
Email address and password field should be remembered.

Comment 1

16 years ago
Confirm
Assignee: bryner → pinkerton
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: when storing login details for autocompletion, the wrong username field is remembered → when storing login details in keychain, the wrong username field is remembered
yeah, we just remember the first field in the form.
Target Milestone: --- → Chimera1.1

Comment 3

15 years ago
Created attachment 147404 [details] [diff] [review]
Better guess at username field

Fixes username guessing to respect autocomplete="off"
Uses the last autocompleteable text field before the password field as
username, rather than the first text field.

Comment 4

15 years ago
This should probably go on the 0.8 branch as well as the trunk

Updated

15 years ago
Attachment #147404 - Flags: review?

Updated

15 years ago
Attachment #147404 - Flags: review?(qa-mozilla)
Attachment #147404 - Flags: review?(josha)
Attachment #147404 - Flags: review?

Comment 5

15 years ago
Comment on attachment 147404 [details] [diff] [review]
Better guess at username field

I looked over, applied, and tested this patch thoroughly. It does indeed fix
the problem at the URL mentioned (I signed up for an account on the forum and
verified the fix there).
Attachment #147404 - Flags: review?(qa-mozilla)
Attachment #147404 - Flags: review?(me)
Attachment #147404 - Flags: review?(joshmoz)
Attachment #147404 - Flags: review+

Updated

15 years ago
Target Milestone: Camino1.1 → Camino0.9

Updated

15 years ago
Attachment #147404 - Flags: superreview?(pinkerton)
Comment on attachment 147404 [details] [diff] [review]
Better guess at username field

sr=pink
Attachment #147404 - Flags: superreview?(pinkerton) → superreview+
landed on trunk.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

15 years ago
Attachment #147404 - Flags: review?(me)
You need to log in before you can comment on or make changes to this bug.