Closed Bug 1848995 Opened 1 years ago Closed 1 years ago

release4 indexing warning 2023-08-16 (and previous dates)

Categories

(Webtools :: Searchfox, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(2 files)

The error in the email is this:

parallel: This job failed:
js -f /home/ubuntu/mozsearch/scripts/js-analyze.js -- 273 /home/ubuntu/mozsearch /mnt/index-scratch/llvm/git/libcxx/modules/std/bitset.inc > /mnt/index-scratch/llvm/analysis/libcxx/modules/std/bitset.inc

From the detailed indexer log the rootmost part of the error this:

(sax.js):969:19 RangeError: NaN is not a valid code point

pointing to this line from a 8-year old sax parser we use. We're feeding it a c++ snippet from the llvm tree and trying to parse it as XUL.

There's probably a bunch of options to fix this, but mostly we shouldn't be treating these .inc files as XUL for all trees, I think.

Another option is to update our sax parser, it seems like the upstream one got this change 6 years ago that would catch this error as well. Or I could just cherry-pick that one-line fix.

Attached file GitHub Pull Request

SAX parser upgrade seems pretty simple and should have minimal fallout

Assignee: nobody → kats
Status: NEW → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Attached file GitHub Pull Request

Turns out our copy had some modifications which I inadvertently dropped when I imported the newer version. The lack of those modifications caused today's release1 indexer to fail. This PR puts back the modifications.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: