1849060 - [gv-junit-fis] Receiving unexpected Principal within RecvNewWindowGlobal

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, task, P1)

Description

[[:owlish] 🦉 PST]

This happens during the error page load. The error message:

Receiving unexpected Principal (http://localhost:4245/assets/www/hello.html) within RecvNewWindowGlobal

MOZ_Assert org.mozilla.geckoview.test  A  Assertion failure: false (Receiving unexpected Principal), at /Users/owlish/code/gecko/dom/ipc/ContentParent.cpp:1330

(http://localhost:4245/assets/www/hello.html is the error page address) Happens because we are trying to load an HTTP resource as the error page in the wrong process. HTTP as error pages is not something that we can easily support even if we implement a custom channel for async redirect to process switch (see bugs 1673763 and 1848701 for context).

What's needed here:

1. Make sure the undesirability of HTTP resource as the error page is communicated in the API documentation
2. Consider having URI validation in GeckoView
3. Change the error page URI in the tests

STR:

Run any of these with Fission enabled:

• NavigationDelegateTest#loadUnknownHost
• NavigationDelegateTest#loadUntrusted
• NavigationDelegateTest#safebrowsingPhishing
• NavigationDelegateTest#safebrowsingMalware
• NavigationDelegateTest#safebrowsingUnwanted
• NavigationDelegateTest#safebrowsingHarmful

Comment 2

[[:owlish] 🦉 PST]

Attachment: Bug 1849060 - Use non-html links for error pages in tests

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14791c645827
Use non-html links for error pages in tests r=geckoview-reviewers,zmckenney

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/14791c645827