Closed Bug 1849214 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 41517 - LoAF: Make sure callbacks don't cancel promise resolver attribution

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox119 fixed)

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41517 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41517
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

LoAF: Make sure callbacks don't cancel promise resolver attribution

Some callbacks (e.g. URLSearchParams.forEach) can be invoked
synchronously. If there is a pending promise resolver, those callbacks
should not cancel it as pending.

Fixed by using the existing user_callback_counter to also account
for promise resolvers.

The callback in the bug is TrustedTypePolicy.CreateHTML, but using
URLSearchParams.forEach in the test as it's more widely supported.

Bug: 1473663
Change-Id: Id0036304d9f8a434de6d0a8a06be3087a1b21e24
Reviewed-on: https://chromium-review.googlesource.com/4790449
WPT-Export-Revision: 3a7743b8fec271cd632a3821d969d554bf837328

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
FAIL : 1

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea94d09f1881 [wpt PR 41517] - LoAF: Make sure callbacks don't cancel promise resolver attribution, a=testonly https://hg.mozilla.org/integration/autoland/rev/f824af5b88bb [wpt PR 41517] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ea94d09f1881
https://hg.mozilla.org/mozilla-central/rev/f824af5b88bb

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.