1849221 - Quick Filter: Persist "keep filters applied" setting on restart

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Elizabeth Mitchell]

Persist a xulStore setting for keep filters applied. This is needed for Bug 1846880.

+++ This bug was initially created as a clone of Bug #1846880 which is a clone of Bug #1833257 +++

Description

On application restart, the user's selection for "Keep filters applied" in Quick Filter settings should be remembered.

102

• Current: On restart, user selected button state is retained
• Desired change: Keep current functionality

115

• Current: On restart, button state is reset to not enabled
• Desired change: On restart, remember the user’s selection and set the button to that state

This returns functionality in 115 to what is the current functionality in 102.

---

Original report from Thomas D. :thomas8) from bug 18233257 comment #0)
Seen on 115.0a1 (2023-05-15) (64-bit), Win10.

From post on TB-Beta, Can the "keep filters applied" toggle be made sticky?

TB 102 used to persist the status of quick filter buttons across TB restart, but Daily doesn't do that any more.

STR

• Switch on Keep filters applied when changing folders and Unread quick filter.
• Restart TB
• Observe status of the filter buttons

Actual

• filter button status not persisted

Expected

• Should probably just persist filter button status as in 102.
• Otherwise persisting filter states should probably be available as an option.
• It's worth noting that the filter text is not persisted, probably by design.
• The rationale here is that the buttons act like view filters, which users may want to have applied always depending on their workflows. Which is different from filter text, which targets specific messages.

Comment 1

[Elizabeth Mitchell]

Attachment: Bug 1849221 - Create XULSTORE setting for Quick Filter keep filters applied. r=#thunderbird-front-end-reviewers

• Create XULSTORE setting that can be persisted

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ab477eb60028
Create XULSTORE setting for Quick Filter keep filters applied. r=freaktechnik

Comment 3

[Elizabeth Mitchell]

Comment on attachment 9349500 [details]
Bug 1849221 - Create XULSTORE setting for Quick Filter keep filters applied. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): Changes from 102 to 115
User impact if declined: Many users want the ability to persist quick filter settings on reload as they could do in 102.
Testing completed (on c-c, etc.): Tested locally, try run, and in c-c
Risk to taking this patch (and alternatives if risky): Low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9349500 [details]
Bug 1849221 - Create XULSTORE setting for Quick Filter keep filters applied. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9349500 [details]
Bug 1849221 - Create XULSTORE setting for Quick Filter keep filters applied. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.3:
https://hg.mozilla.org/releases/comm-esr115/rev/ddb369e78b85