1849240 - Add an event when a user closes the shopping sidebar

Status: VERIFIED FIXED

(Firefox Graveyard :: Shopping, task)

Description

[Perry McManis [:perry.mcmanis]]

An event should be fired when a user closes the side bar. There is an associated extra with for capturing how they closed it, as multiple things can close the side bar.

Comment 1

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1849240 - Add an event when a user closes the shopping sidebar r?gijs,travislong

Comment 2

[Phabricator Automation]

Comment on attachment 9349819 [details]
Bug 1849240 - Add an event when a user closes the shopping sidebar r?gijs,travislong

Revision D186637 was moved to bug 1849239. Setting attachment 9349819 [details] to obsolete.

Comment 3

[Phabricator Automation]

Comment on attachment 9349819 [details]
Bug 1849240 - Add an event when a user closes the shopping sidebar r?gijs,travislong

Revision D186637 was moved to bug 1849241. Setting attachment 9349819 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c0677c66f23
Add an event when a user closes the shopping sidebar r=TravisLong,Gijs

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out as requested by the dev for needing changes.

Backout link: https://hg.mozilla.org/integration/autoland/rev/711221b0116d10a72d3c7bdd9b79f31c6b218c96

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad1666f0ecdd
Add an event when a user closes the shopping sidebar r=TravisLong,Gijs

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ad1666f0ecdd

Comment 8

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Nightly 119.0a1 (2023-09-06) on Windows 10, macOS 11 and Ubuntu 20.04.
Both the "surface_closed" and "address_bar_icon_clicked" ping with closed action is successfully displayed in about:glean after clicking the
[X] - close button and "Fakespot Address bar icon" to close the shopping sidebar.