1849319 - Remove SrcNoteType::Null

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

The end of source notes is always known and there's no need to use dedicate type for terminator.

Comment 1

[Tooru Fujisawa [:arai]]

actually, this was wrong. the end of source notes pointed by ImmutableScriptData::noteLength includes the padding, which is filled by Null.
So we still need some kind of padding byte, while we could remove a case where whole 32-bits are filled by padding if there's other way to fill the padding.

Comment 2

[Tooru Fujisawa [:arai]]

XDelta with 0 could be used as padding.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1849319 - Remove SrcNoteType::Null. r?bthrall!

Use SrcNoteType::XDelta with ext-delta == 0 as terminator instead.
Also remove the 4-bytes padding at the end of source notes array.

Depends on D186917

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc02e5f4ed22
Remove SrcNoteType::Null. r=bthrall

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cc02e5f4ed22