1849358 - Add SrcNoteType::NewLineColumn and SrcNoteType::SetLineColumn

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

SrcNoteType::ColSpan often follows SrcNoteType::NewLine or SrcNoteType::SetLine, and
having a compound type should reduce the source note size

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1849358 - Part 1: Add SrcNoteType::NewLineColumn. r?bthrall!

When SrcNoteType::NewLine is immediately followed by SrcNoteType::ColSpan,
combine them into SrcNoteType::NewLineColumn.

Depends on D186919

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1849358 - Part 2: Add SrcNoteType::SetLineColumn. r?bthrall!

When SrcNoteType::SetLine is immediately followed by SrcNoteType::ColSpan,
combine them into SrcNoteType::SetLineColumn.

Depends on D186920

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1849358 - Part 3: Simplify BytecodeRangeWithPosition::updatePosition. r?bthrall!

Depends on D186921

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1849358 - Part 4: Update comment. r?bthrall!

Depends on D186922

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fbee7d48d29
Part 1: Add SrcNoteType::NewLineColumn. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/553cb71e0648
Part 2: Add SrcNoteType::SetLineColumn. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/c973f1864496
Part 3: Simplify BytecodeRangeWithPosition::updatePosition. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/4c53f6af480f
Part 4: Update comment. r=bthrall

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4fbee7d48d29
https://hg.mozilla.org/mozilla-central/rev/553cb71e0648
https://hg.mozilla.org/mozilla-central/rev/c973f1864496
https://hg.mozilla.org/mozilla-central/rev/4c53f6af480f