1849405 - Improve damp tests for pause and stepping to properly cover map scope scenarios

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

We currently test have basic tests for pausing and stepping in original files. See https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/devtools/addon/content/tests/debugger/custom.js#84-132

These do not seem to properly cover all scenarios as there are no significant improvements or regressions when map scopes are turned on.

For map scopes the differences are significant when a pause or step jumps to a new source, lets cover that as part of the test.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1849405 - [devtools] Make sure the step-in test covers stepping into a new source r=#devtools-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfbd0bd9bc62
[devtools] Make sure the step-in test covers stepping into a new source r=perftest-reviewers,devtools-reviewers,sparky,ochameau

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cfbd0bd9bc62

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

== Change summary for alert #39574 (as of Sat, 16 Sep 2023 13:22:51 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
24%	damp custom.jsdebugger.stepIn.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	599.81 -> 458.59
23%	damp custom.jsdebugger.stepIn.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	599.96 -> 463.45
14%	damp custom.jsdebugger.stepIn.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	716.11 -> 617.04
13%	damp custom.jsdebugger.stepIn.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	705.41 -> 612.04
9%	damp custom.jsdebugger.stepIn.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	763.88 -> 696.23
...	...	...	...	...
6%	damp custom.jsdebugger.project-search.first-search-result.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	131.15 -> 123.19

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39574

Comment 5

[Hubert Boma Manilla (:bomsy)]

Thanks!
This improvements are expected as the new custom.jsdebugger.stepInNewSource.DAMP subtest added (runs before the custom.jsdebugger.stepIn.DAMP), the step-in-test.js has already been parsed and the symbols built, so the stepIn test would run slightly faster.