1849440 - Fix float-to-nscoord conversion in LengthPercentage::Resolve

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Daniel Holbert [:dholbert]]

https://searchfox.org/mozilla-central/rev/78af6dbe0591376d9d5d678adaf21aa69dcc3506/layout/style/ServoStyleConstsInlines.h#711,720

nscoord LengthPercentage::Resolve(T aPercentageGetter, U aRounder) const {
...
    return 0.0f;

This ^ 0.0f should just be 0, to match the return type (nscoord which is a typedef for int32_t) and avoid an implicit conversion.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1849440: Return 0 instead of 0.0f from a nscoord-returning function. r?emilio

This doesn't change behavior; this just avoids an implicit float-to-nscoord
conversion that we were inadvertently triggering for no reason.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/981402028450
Return 0 instead of 0.0f from a nscoord-returning function. r=emilio

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/981402028450