1849476 - messages.move/copy() doesn't set mail.last_msg_movecopy_target_uri

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

When using messenger.messages.move(), the Move to "foldername" again menuitem is not updated. Not sure this should always be the case, but when it is a user-initiated move that the extension is executing, this would be useful.

Comment 1

[John Bieling]

There are discussions about adding undo support as well which also fits the user-initiated case. How about adding a flag to messages.move() to let the developer enable this user-initiated mode, which will handle the move operation identical to a move in the UI?

Any suggestions for the flag name?

Or would you rather suggest dealing with undo and the recent-moves-list separately?

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

I think the recent moves list should be updated automatically, not a separate function. In terms of the flag name, I'd go with something that describes the function instead of the technical detail, but I'd need to think on it a bit. My gut says userInitiated, and you'd have to consider if the default should be true or false. This would depend on if the most typical use case is user moves, or background moves.

Comment 3

[John Bieling]

Attachment: Bug 1849476 - Make messages.move/copy() set mail.last_msg_movecopy_* preferences. r=#thunderbird-reviewers

This patch updates the last_msg_movecopy_* preferences, after
move/copy operations, which have been declared as user actions.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0fbdd3be3231
Make messages.move/copy() set mail.last_msg_movecopy_* preferences. r=aleca