Closed
Bug 1849678
Opened 2 years ago
Closed 2 years ago
Fix obsolete comments
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
120 Branch
| Tracking | Status | |
|---|---|---|
| firefox120 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(8 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
There are several comments that refer things that's renamed or removed.
| Assignee | ||
Comment 1•2 years ago
|
||
| Assignee | ||
Comment 2•2 years ago
|
||
Depends on D186763
| Assignee | ||
Comment 3•2 years ago
|
||
Depends on D186764
| Assignee | ||
Comment 4•2 years ago
|
||
Depends on D186765
| Assignee | ||
Comment 5•2 years ago
|
||
Depends on D186766
| Assignee | ||
Comment 6•2 years ago
|
||
Depends on D186767
| Assignee | ||
Comment 7•2 years ago
|
||
Depends on D186768
| Assignee | ||
Comment 8•2 years ago
|
||
Depends on D186769
Updated•2 years ago
|
Attachment #9350085 -
Attachment description: WIP: Bug 1849678 - Part 1: Rewrite old parse node comments. r?bthrall! → Bug 1849678 - Part 1: Rewrite old parse node comments. r?bthrall!
Updated•2 years ago
|
Attachment #9350086 -
Attachment description: WIP: Bug 1849678 - Part 2: Rewrite old token kind comments. r?bthrall! → Bug 1849678 - Part 2: Rewrite old token kind comments. r?bthrall!
Updated•2 years ago
|
Attachment #9350087 -
Attachment description: WIP: Bug 1849678 - Part 3: Rewrite old JSOp comments. r?bthrall! → Bug 1849678 - Part 3: Rewrite old JSOp comments. r?bthrall!
Updated•2 years ago
|
Attachment #9350088 -
Attachment description: WIP: Bug 1849678 - Part 4: Rewrite old TryNoteKind comments. r?bthrall! → Bug 1849678 - Part 4: Rewrite old TryNoteKind comments. r?bthrall!
Updated•2 years ago
|
Attachment #9350089 -
Attachment description: WIP: Bug 1849678 - Part 5: Rewrite old ReadOnlyCompileOptions comment. r?bthrall! → Bug 1849678 - Part 5: Rewrite old ReadOnlyCompileOptions comment. r?bthrall!
Updated•2 years ago
|
Attachment #9350090 -
Attachment description: WIP: Bug 1849678 - Part 6: Rewrite comment for getNslots. r?bthrall! → Bug 1849678 - Part 6: Rewrite comment for getNslots. r?bthrall!
Updated•2 years ago
|
Attachment #9350091 -
Attachment description: WIP: Bug 1849678 - Part 7: Rewrite old JSID comment. r?bthrall! → Bug 1849678 - Part 7: Rewrite old JSID comment. r?bthrall!
Updated•2 years ago
|
Attachment #9350092 -
Attachment description: WIP: Bug 1849678 - Part 8: Fix include comments. r?bthrall! → Bug 1849678 - Part 8: Fix include comments. r?bthrall!
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/5d830743f8f9
Part 1: Rewrite old parse node comments. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/1b5bee829bd9
Part 2: Rewrite old token kind comments. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/00e09d1b4e55
Part 3: Rewrite old JSOp comments. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/3cb292f15f84
Part 4: Rewrite old TryNoteKind comments. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/5798a5483761
Part 5: Rewrite old ReadOnlyCompileOptions comment. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/be3da1db159b
Part 6: Rewrite comment for getNslots. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/3d06c49b87b3
Part 7: Rewrite old JSID comment. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/f7a9ab9bffd9
Part 8: Fix include comments. r=bthrall
Comment 10•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5d830743f8f9
https://hg.mozilla.org/mozilla-central/rev/1b5bee829bd9
https://hg.mozilla.org/mozilla-central/rev/00e09d1b4e55
https://hg.mozilla.org/mozilla-central/rev/3cb292f15f84
https://hg.mozilla.org/mozilla-central/rev/5798a5483761
https://hg.mozilla.org/mozilla-central/rev/be3da1db159b
https://hg.mozilla.org/mozilla-central/rev/3d06c49b87b3
https://hg.mozilla.org/mozilla-central/rev/f7a9ab9bffd9
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox120:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•