1849737 - [wpt-sync] Sync PR 41584 - Fix influence of <slot> on dir=auto computation of its shadow tree ancestors.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41584 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41584
Details from upstream follow.

L. David Baron <[e-mail]> wrote:

Fix influence of <slot> on dir=auto computation of its shadow tree ancestors.

This change treats a \<slot> element as being a strong character, of its
resolved directionality, when resolving dir=auto on its shadow tree
ancestor.

This is behind the RuntimeEnabledFeatures::CSSPseudoDirEnabled() flag
because we're hoping to ship that feature soon and it makes sense to
ship related changes to direction handling all at once rather than
piecemeal.

This is based on the proposed behavior described in:
https://github.com/whatwg/html/issues/3699#issuecomment-951423468
which is in the process of being specified in:
https://github.com/whatwg/html/pull/9166
https://github.com/whatwg/html/pull/9452
https://github.com/whatwg/html/pull/9554

This fixes the failures of:
external/wpt/shadow-dom/directionality/dir-shadow-30.html
external/wpt/shadow-dom/directionality/dir-shadow-34.html
in the still-unlanded WPT PR at
https://github.com/web-platform-tests/wpt/pull/29820

This also changes the existing WPT
html/dom/elements/global-attributes/dir-slots-directionality.tentative.html
in the following ways:

• split the test into separate test() functions to get separate results
• add a sixth test testing \<slot dir=auto>\</slot>
• add tests of the :dir() selector for each test (where Chromium fails
  this test for test 1)
• change the expected result of the fourth test to match this code
  change and the proposed specification

Bug: 576815
Change-Id: I83551e9bc5807109c5318bace486cfc93fc25bbb
Reviewed-on: https://chromium-review.googlesource.com/4800366
WPT-Export-Revision: ddbefa002eb331e64513b0c7bf9b84343833c822

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d83a1a101bf5e838de9f7d6a2d81560812867bf

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 4

Chrome

OK : 1
PASS: 4
FAIL: 2

Safari

OK : 1
PASS: 5
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /html/dom/elements/global-attributes/dir-slots-directionality.tentative.html [wpt.fyi]
  • Slots: Directionality: dir=auto on host with Arabic shadow tree content: FAIL

New Tests That Don't Pass

• /html/dom/elements/global-attributes/dir-slots-directionality.tentative.html [wpt.fyi]
  • Slots: Directionality: dir=rtl on slot: FAIL (Chrome: FAIL, Safari: PASS)
  • Slots: Directionality: dir=auto on host with Arabic shadow tree content: FAIL (Chrome: PASS, Safari: PASS)
  • Slots: Directionality: dir=auto in shadow tree with Arabic light tree content: FAIL (Chrome: FAIL, Safari: PASS)
  • Slots: Directionality: dir=auto on slot with Arabic light tree content: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35f3910b4ddd
[wpt PR 41584] - Fix influence of <slot> on dir=auto computation of its shadow tree ancestors., a=testonly
https://hg.mozilla.org/integration/autoland/rev/879805c592c6
[wpt PR 41584] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/35f3910b4ddd
https://hg.mozilla.org/mozilla-central/rev/879805c592c6