Disable translations on Fx117 for the Nimbus holdout
Categories
(Firefox :: Translations, task, P1)
Tracking
()
People
(Reporter: gregtatum, Assigned: gregtatum)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
In Bug 1849030 I registered the translations pref with Nimbus, but did not disable the pref by default. There is no ifdef flag for Release but not Beta. At this point in order to ship the Nimbus experience we need the feature off by default. I'm going to attach a patch that should be uplifted to Beta for 117, but not landed anywhere else.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]: As discussed with :ryanvm, for sending out translations I had neglected to disable translations due to a misunderstanding on my part and what I described above.
|
|
Assignee | |
Comment 3•3 years ago
|
||
Comment on attachment 9349894 [details]
Bug 1849756 - Disable translations on Fx117 for the Nimbus holdout; r?nordzilla!
Beta/Release Uplift Approval Request
- User impact if declined: Users will get the translations feature before the holdback study is ready, and then the feature will be pulled away.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a one line pref flip to enable/disable the feature, and is low risk to change.
- String changes made/needed:
- Is Android affected?: Yes
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
Note: This should not land in Fx118.
|
||
Updated•3 years ago
|
|
|
||
Comment 5•3 years ago
|
||
Comment on attachment 9349894 [details]
Bug 1849756 - Disable translations on Fx117 for the Nimbus holdout; r?nordzilla!
Approved for 117.0rc2.
|
|
||
Updated•3 years ago
|
|
|
||
Comment 9•3 years ago
|
||
(In reply to Pulsebot from comment #8)
https://hg.mozilla.org/releases/mozilla-release/rev/27de51e74c19
Greg, this was due to failures in browser_translations_telemetry_panel_auto_offer.js where I assume the test was expecting the popup to show by default. We might want to land a follow-up for 118+ which explicitly sets this pref in the test?
Description
•