Closed Bug 1849778 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 41590 - Revert "Rewrite to re-enable pointerevent_attributes_nohover_pointers WPT"

Categories

(Core :: DOM: Events, task, P4)

Product:
Core
Component:
DOM: Events
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41590 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41590
Details from upstream follow.

Emily Shack <emshack@chromium.org> wrote:

Revert "Rewrite to re-enable pointerevent_attributes_nohover_pointers WPT"

This reverts commit 53ad26c3461cffe8960e2f3b0e9c9a18d6ae5883.

Reason for revert: Likely culprit for builder failure: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/54291/overview

Original change's description:

Rewrite to re-enable pointerevent_attributes_nohover_pointers WPT

The test was written using complicated event-driven logic, and had two
tests hooked up together. This CL switches it to a simpler
Promise-based approach like newer tests in the same folder, expecting
to address the leak issue.

The CL also corrects an error message in testdriver-vendor.js that
misled our initial investigation.

Fixed: 1446799
Change-Id: If5cf1e9c0856a6beea4441a505fb320bf30344ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4794391
Commit-Queue: Kevin Ellis \<kevers@chromium.org>
Reviewed-by: Kevin Ellis \<kevers@chromium.org>
Auto-Submit: Mustaq Ahmed \<mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1186659}

Change-Id: I535de62d578a6a8d178816940639457ef2cd981f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/4804464
WPT-Export-Revision: a182f4166b9e0ab47cc1ff69fcc66e554b91b835

Component: web-platform-tests → DOM: Events
Product: Testing → Core
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9d6234cbb7a [wpt PR 41590] - Revert "Rewrite to re-enable pointerevent_attributes_nohover_pointers WPT", a=testonly

https://hg.mozilla.org/mozilla-central/rev/d9d6234cbb7a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.