1849869 - Vendored proc-macro2 doesn't compile

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Henri Sivonen (:hsivonen)]

The vendored version of proc-macro2 no longer compiles with the current Rust release (1.71.1). Update to the latest from crates.io to get a version that compiles.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1849869 - Update proc-macro2 to 1.0.66.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ef66afbcd94
Update proc-macro2 to 1.0.66. r=supply-chain-reviewers,glandium

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7ef66afbcd94

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler]]

[Tracking Requested - why for this release]: Apparently this affects ESR 115 - see bug 1850693.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This patch grafts cleanly to Beta, but ESR115 is going to need a branch-specific patch from the looks of it.

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1849869 - Update proc-macro2 to 1.0.66. (ESR version)

Comment 8

[Henri Sivonen (:hsivonen)]

Comment on attachment 9350003 [details]
Bug 1849869 - Update proc-macro2 to 1.0.66.

Beta/Release Uplift Approval Request

• User impact if declined: No end user impact in the usual sense. The impact is on what rustc versions can be used to compile Firefox 118.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The alternative is not to take this and not to accommodate a rustc update for compiling Firefox 118.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 9

[Henri Sivonen (:hsivonen)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

This patch grafts cleanly to Beta,

Requested uplift as implied by this observation.

but ESR115 is going to need a branch-specific patch from the looks of it.

I posted a different changeset for ESR that I made using the same mechanical update procedure (specifically cargo update -p proc-macro2 --precise "1.0.66"). Sorry about the delay.

Comment 10

[Henri Sivonen (:hsivonen)]

Comment on attachment 9352432 [details]
Bug 1849869 - Update proc-macro2 to 1.0.66. (ESR version)

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Allows ESR to be compiled with newer rustc.
• User impact if declined: No direct end user impact in the usual sense from this patch alone.
• Fix Landed on Version: 119
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch contains relatively constrained compiler compatibility tweaks directly from the crates.io release of the vendored crate.

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9350003 [details]
Bug 1849869 - Update proc-macro2 to 1.0.66.

Approved for 118.0b8, thanks.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba11efce1e9d

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba11efce1e9d

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9352432 [details]
Bug 1849869 - Update proc-macro2 to 1.0.66. (ESR version)

Approved for ESR 115.3, thanks.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/aab12f291219

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-esr115/rev/aab12f291219