Closed Bug 1849874 Opened 1 year ago Closed 1 year ago

Update from packed_simd_2 to packed_simd

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox-esr115 fixed, firefox119 fixed)

RESOLVED FIXED
119 Branch
Tracking Status
firefox-esr115 --- fixed
firefox119 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(2 files)

packed_simd_2 0.3.8 no longer compiles. Version 0.3.9 is back under the packed_simd name.

Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/443c7bf9d76b Update from packed_simd_2 to packed_simd. r=supply-chain-reviewers,glandium
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch

Can you get this uplifted to esr115?

Flags: needinfo?(hsivonen)

(In reply to Mike Hommey [:glandium] from comment #4)

Can you get this uplifted to esr115?

Uploaded an ESR patch for review.

Flags: needinfo?(hsivonen)

Comment on attachment 9352441 [details]
Bug 1849874 - Update from packed_simd_2 to packed_simd. (ESR version)

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Enables ESR to be compiled with SIMD enabled with newer rustc.
  • User impact if declined: If distributors who compile their own copy of ESR put a higher priority on compiling with a newer rustc than on having SIMD enabled, there will be a user-visible performance regression for decoding/encoding stretches of ASCII text.
  • Fix Landed on Version: 119
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is low-risk due to it containing straight-forward upstream fixes for compiler compatibility. The alternative is not to take this, in which case ESR either needs to be compiled with older rustc or suffer the performance loss of loss of SIMD for certain operations.
Attachment #9352441 - Flags: approval-mozilla-esr115?

Comment on attachment 9352441 [details]
Bug 1849874 - Update from packed_simd_2 to packed_simd. (ESR version)

Approved for ESR 115.3, thanks.

Attachment #9352441 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
See Also: → 1860935
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: