1849880 - Home.jsx: ESLint warning 'React Hook useEffect has missing dependencies'

Status: RESOLVED FIXED

(Firefox :: Pocket, task)

Description

[Mark Banner (:standard8)]

Running ESLint with warnings on browser/components/pocket/content/panels/js/components/Home/Home.jsx is currently giving a warning:

$ ./mach eslint --warnings browser/components/pocket/content/panels/js/components/Home/Home.jsx
browser/components/pocket/content/panels/js/components/Home/Home.jsx
  71:6  warning  React Hook useEffect has missing dependencies: 'articles' and 'hideRecentSaves'. Either include them or remove the dependency array.  react-hooks/exhaustive-deps (eslint)

It looks like this code was added in bug 1797595.

I don't know enough about the code to know if these should be added, or if this rule should be ignored. Scott, could you take a look please?

Overall I'd like to change the rule from a warning to an error, since warnings tend to get ignored and never resolved.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1849880 - Save to Pocket fixing eslint dependencies warning around useEffect.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0f462441a05
Save to Pocket fixing eslint dependencies warning around useEffect. r=gvn

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d0f462441a05