Closed Bug 184994 Opened 22 years ago Closed 18 years ago

GUI for options on where to force link with target (new tab or re-use current window)

Categories

(Camino Graveyard :: Tabbed Browsing, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED WONTFIX
Camino1.5

People

(Reporter: so.there, Assigned: froodian)

References

Details

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021201 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021201 Chimera/0.6+

A preference should be added whereby links with target="blank/new/other" or
onClick=newwindow() (or the like) should open in new tabs, as opposed to the
current behavior, where only the option to automatically open new tabs for
"loading a page requested by another application" is available.  this allows
users to avoid Command-Click-ing every link they want to open in a new tab.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
user_pref("browser.block.target_new_window", true);

I agree this should be in the prefs UI.
Summary: "open in new window" should open in new tab - if desired → "open in new window" should open in new tab - if desired
OK, I think you mean something different - do you mean that when a new window
would pop up, it should go into a new tab instead? The pref I gave doesn't do
that, it loads new windows into the same window.
I think that's what he wants, a totally new checkbox in the Prefs, something like
[x] Always Open links with a Target inside a new Tab

Might be useful for those who want tabbed browsing only as you never know if a
link as a Target or not.
-> smfr
Assignee: pinkerton → sfraser
Sure.
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 186211 has been marked as a duplicate of this bug. ***
I like this idea.
Summary: "open in new window" should open in new tab - if desired → "open in new window" should open in new tab - if desired (such as popup windows)
Is there a similar bug for all of Mozilla? I recently had to give up Galeon, and
I really liked this feature of it.
Simon, any news on this?
This is in Tabbroweser Extentions for Firebird.  I believe they call it
single-window mode.  It's one of my favourite Firebird features that Camino
doesn't have.
I would like this applied to Mozilla too.  At least I think what
I want is the same.  When I middle click (open on tab) on a link
that is configured to do a popup, I end up with a blank tab.
I'd like the popup to open in the tab as I requested.
Sorry for the late follow up.

Yes, what I want is that an option to open the link in a new tab when it is
going to open a link in new window, especially when it is a newwindow javascript
as the single window mode of Firefox extension.
(In reply to comment #12)
> Sorry for the late follow up.
> 
> Yes, what I want is that an option to open the link in a new tab when it is
> going to open a link in new window, especially when it is a newwindow javascript
> as the single window mode of Firefox extension.


This would be wonderful (it's the one and only thing i miss from Safari while
using Saft, any ETA on when this might make it into the nightly builds?
(In reply to comment #12)
> Sorry for the late follow up.
> 
> Yes, what I want is that an option to open the link in a new tab when it is
> going to open a link in new window, especially when it is a newwindow javascript
> as the single window mode of Firefox extension.

HOwever, even the FireFox extension fails on javascript links that want to open
a new window -- they will open a new window, not tab.  We need a powerful option
that will be able to open javascript links in tabs. 
something we should look into, i think we can hook in at the window creation
level to do the right thing. My only concern is making sure the JS engine still
sees the "windows" as tabs. It might all just work. Worth investigating as we
get this request a lot.
Target Milestone: --- → Camino0.9
I think this functionality, or at least part of it (targets; not positive about
the JS part), is now on the trunk from the Aviary branch landing...making this
bug dependent on hooking up the trunk's single-window mode (bug 274143).
Depends on: caminoSWM
This might be a good idea, but its not an 0.9 blocker. If this happens for 0.9,
great, but we shouldn't wait on it.
Target Milestone: Camino0.9 → Camino1.0
Firefox has has this for a while now and it's a wonderfull option. It makes
browsing even nicer then it was.

What is keeping us from doing this aswell? Do we need our own code to do this,
or can we hook up to the prefs from core?

This would really be a great thing to have.
Summary: "open in new window" should open in new tab - if desired (such as popup windows) → Force link in new tab or re-use current window options.
Regarding comment #1, comment #2 and comment #3, a natural behaviour would be
that if browser.block.target_new_window is set then the link behaves just like a
plain link. Thus, Open in New Window and Open in New Tab should still be
available, but the default clicks should work as normal, e.g. (dependent on the
user's configuration) left-click opens in the current window, middle-click opens
in a new tab.

If I understand correctly, this behaviour would separate the functionality issue
from the UI issue. The latter, as it pertains to
browser.block.target_new_window, would then be unchanged by the fixing of this bug.

I'm not sure how the above suggestion relates to existing functionality in the
different applications.
Bump.

Any work done on this?
Assignee: sfraser_bugs → pinkerton
QA Contact: bugzilla
Bump.

Any work done on this?
QA Contact: bugzilla
(In reply to comment #21)
> Bump.
> 
> Any work done on this?

This depends on bug 274143; we found out in that bug that single window mode was
not designed to be embedding-friendly.  Probably a 1.1 feature at best.
Summary: Force link in new tab or re-use current window options. → Force link with target into new tab or re-use current window options.
unfortunately :(
Target Milestone: Camino1.0 → Camino1.1
Firefox 1.5b has a option for fourceing new windows to open in tabs...
Depends on: 323810
Firefox is not an embedding app.  This is markes as depending on bug 323810 for a reason.
Target Milestone: Camino1.1 → Camino2.0
Moving this back to 1.1 for now, since the core changes landed on 1.8 branch.  They still need hooking up in Camino (bug 274143), and we may only get a subset of them in 1.1 (what we had in 1.0) and maybe no GUI, but syncing milestones anyway.
QA Contact: bugzilla → tabbed.browsing
Target Milestone: Camino2.0 → Camino1.1
Target Milestone: Camino1.1 → Camino2.0
Target Milestone: Camino2.0 → Camino1.1
*** Bug 172718 has been marked as a duplicate of this bug. ***
SWM is available now (well, tomorrow's nightly) on 1.8branch and trunk with GUI option for "new tabs".

Keeping open for the moment in case we decide we want to allow "reuse" as a GUI option, too (we may not).
Summary: Force link with target into new tab or re-use current window options. → GUI for options on where to force link with target (new tab or re-use current window)
Taking, for if we decide to do this.
Assignee: mikepinkerton → stridey
WONTFIX per IRC.  It's been over a month, and not a single person has requested access to the 'reuse' setting for this pref.  We can provide the info for it on the website.  "I think we set the right defaults for 90% of the people, and make the 10% who are crazy dig to satisfy their insanity."
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
(In reply to comment #30)
> WONTFIX per IRC.  It's been over a month, and not a single person has requested
> access to the 'reuse' setting for this pref.  We can provide the info for it on
> the website.  "I think we set the right defaults for 90% of the people, and
> make the 10% who are crazy dig to satisfy their insanity."
> 

well, I think few request it because you can get it as part of CamiTools. With camitools you get the reuse pref, and with camino "native" you get the open in new tab. I guess it'd be cool if it was all native. and i have it set to reuse, btw.
Camino has native ability to "reuse", just not GUI for it.
well yeah, that's what i meant, it'd be nice if there was a gui for it.
You need to log in before you can comment on or make changes to this bug.