Closed Bug 1849947 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 41611 - Report space shortage for non-fitting grid items.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox119 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 41611 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41611
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Report space shortage for non-fitting grid items.

Prior to crrev.com/c/4512177 , we accidentally used the tallest
unbreakable block-size as space shortage for grid containers, when it
broke inside because some item would have to be pushed to a subsequent
column. The CL made sure that we wouldn't mix up space shortage and
tallest unbreakable block-size (those two values share storage in
NGLayoutResult). And with that, the truth was revealed: the grid layout
algorithm doesn't always report space shortage. This could cause the
column layout algorithm to cowardly give up and finish, since it
wouldn't be able to make any further progress, not knowing the column
block-size stretch amount. This would result in creating more columns
than specified.

When we decide that a grid item belongs in a subsequent column, and
we're in column stretch mode (i.e. balancing is enabled, and we're past
the initial balancing pass), lay out the grid item anyway, so that we
can calculate the space shortage.

Bug: 1474979
Change-Id: I714734d704eb26dd0e61966120785948522f429d

Reviewed-on: https://chromium-review.googlesource.com/4807905
WPT-Export-Revision: 085396879d92dfcb3290a9c25f94cded70fde334

Component: web-platform-tests → Layout: Columns
Product: Testing → Core
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0cc280bfa4cc [wpt PR 41611] - Report space shortage for non-fitting grid items., a=testonly

https://hg.mozilla.org/mozilla-central/rev/0cc280bfa4cc

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox119: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
You need to log in before you can comment on or make changes to this bug.