1850103 - [wpt-sync] Sync PR 41632 - Delete codec-specific fields etc from RTCEncodedVideoFrameMetadata

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41632 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41632
Details from upstream follow.

Tony Herre <[e-mail]> wrote:

Delete codec-specific fields etc from RTCEncodedVideoFrameMetadata

Delete the additional metadata fields added to
RTCEncodedVideoFrameMetadata behind a flag in hackathons over the last
year which didn't end up being part of the setMetadata() launch required
for doing encoded media re-sending.
(https://chromestatus.com/feature/5116073827893248).

Being able to control these would likely be needed if we want to create
Encoded Frames from JS - in that case we can revert this cl & adjust
accordingly.

Change-Id: Ia961ba38362cd0e7e53dd59995b28b8c8c7c6135
Bug: b:290664482
Reviewed-on: https://chromium-review.googlesource.com/4678824
WPT-Export-Revision: 0433b6fb1d2eb82ba63c492da4d6d4e3855a019d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=24aafb6b147c0c63c4ba28a581ef31dc34804608

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-encoded-transform/set-metadata.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
  • [VP8] setMetadata() carries over codec-specific properties: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /webrtc-encoded-transform/set-metadata.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0da4a1d0ef56
[wpt PR 41632] - Delete codec-specific fields etc from RTCEncodedVideoFrameMetadata, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7e80caac0323
[wpt PR 41632] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0da4a1d0ef56
https://hg.mozilla.org/mozilla-central/rev/7e80caac0323