1850182 - [wpt-sync] Sync PR 41648 - Check http protocol when emitting resource timing entry

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 41648 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/41648
Details from upstream follow.

Hao Liu <[e-mail]> wrote:

Check http protocol when emitting resource timing entry

Currently when a resource load via file protocol fails, a resource
timing is emitted. We should only emit resource timing for http(s)
resources.

This CL is to fix this issue. The ResourceResponse::ShouldPopulateResourceTiming() method used for
checking protocol when load is successful checks if the
ResourceResponse::current_request_url_ is HTTP or the web bundle url
is valid.

However when the load fails, the ResourceResponse::current_request_url_
could be null, so we use ResourceRequest::url_, since we are only
checking for protocols.

Bug: 1472922
Change-Id: I674b2041f1911e9c6c04863dc38fc64a28be27af
Reviewed-on: https://chromium-review.googlesource.com/4799574
WPT-Export-Revision: c7503ea76e2e9a36b3e6f7990d104b5c5685a4e4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cf5aecc5da74a84bafe722fea383751637010c0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1
ERROR: 1

Chrome

OK : 2
PASS : 2

Safari

OK : 1
PASS : 1
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /resource-timing/resource-timing-failed-fetch.html [wpt.fyi]
  • Resource fetched by HTTP protocol should have resource timing entry emitted, even when the fetch failed.: FAIL

New Tests That Don't Pass

• /resource-timing/resource-timing-failed-fetch-web-bundle.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /resource-timing/resource-timing-failed-fetch.html [wpt.fyi]
  • Resource fetched by HTTP protocol should have resource timing entry emitted, even when the fetch failed.: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aabcfc34944
[wpt PR 41648] - Check http protocol when emitting resource timing entry, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4017c91d92cf
[wpt PR 41648] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9aabcfc34944
https://hg.mozilla.org/mozilla-central/rev/4017c91d92cf