1850357 - Avoid an allocation in DrawEventRecorderPrivate::DetachResources

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Markus Stange [:mstange]]

It appears that, on Windows, the constructors of unordered_map and unordered_set allocate memory: https://share.firefox.dev/45q3ktD

I'll try to change this to use the move constructor.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1850357 - Use move constructor of unordered_map and unordered_set in DetachResources(). r=jrmuizel

Comment 2

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1850357 - Use mozilla::HashSet in DrawEventRecorder instead of unordered_set. r=jrmuizel

On Windows, unordered_set appears to allocate memory for empty sets.

Comment 3

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1850357 - Use mozilla::HashMap in DrawEventRecorder instead of unordered_map. r=jrmuizel

On Windows, unordered_map appears to allocate memory for empty sets.

Depends on D186952

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1850357 - Use nsTHashSet in DrawEventRecorder instead of unordered_set. r=jrmuizel

On Windows, unordered_set appears to allocate memory for empty sets.

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1850357 - Use nsTHashMap in DrawEventRecorder instead of unordered_map. r=jrmuizel

On Windows, unordered_map appears to allocate memory for empty sets.

Depends on D186958

Comment 6

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=b82f0f37c3dd3b8b7b940cdad614adc8ba087f48

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eef78049649b
Use nsTHashSet in DrawEventRecorder instead of unordered_set. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/abbb0b7a761b
Use nsTHashMap in DrawEventRecorder instead of unordered_map. r=jrmuizel

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eef78049649b
https://hg.mozilla.org/mozilla-central/rev/abbb0b7a761b

Comment 9

[Markus Stange [:mstange]]

Before: https://share.firefox.dev/3qHJTxG 301 samples
After: https://share.firefox.dev/3qZY690 64 samples

On nightly, the free(nullptr) shows up a little still.