1850535 - implement registerTaskCleanup() hook

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task)

Description

[Johannes]

Extend the add_task helper to emit a signal when a task has ended so other helpers can hook into it to do some after task cleanup.

Comment 1

[Johannes]

Attachment: Bug 1850535 - mochitest task cleanup function support - r?#credential-management-reviewers!

Helpers and tests can now hook into SimpleTest.registerTaskCleanupFunction to
provide a code that will be executed after the current task is finished. In it,
for example, state can be cleaned up.

Comment 2

[Johannes]

Attachment: Bug 1850535 - mochitest task cleanup function example usage - r?#credential-management-reviewers!

Switch a sample test to use storeLoginsDuringTask(...loginInfos) and
SimpleTest.setContentForTask(html), which are powered by task cleanup fn.

Depends on D187211

Comment 3

[Johannes]

Attachment: Bug 1850535 - mochitest task cleanup function based formAutofillResult and setPreferencesForTask and their use - r?#credential-management-reviewers!

Rewrite test_autocomplete_autofill_related_realms_no_dupes.html and introduce

• SimpleTest.setPreferencesForTask(...preferences)
• storeLoginsDuringTest(...loginInfos)
• formAutofillResult(formId)

which handles state cleanup between tests and tasks.

Depends on D187271

Comment 4

[Johannes]

Attachment: Bug 1850535 - use new task based helpers - r?#credential-management-reviewers!

Depends on D187435

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480dbe152462
mochitest task cleanup function support - r=credential-management-reviewers,sgalich,jmaher
https://hg.mozilla.org/integration/autoland/rev/b01839e48205
mochitest task cleanup function example usage - r=credential-management-reviewers,dimi
https://hg.mozilla.org/integration/autoland/rev/fc9333c3b9f7
mochitest task cleanup function based formAutofillResult and setPreferencesForTask and their use - r=credential-management-reviewers,sgalich,dimi

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/480dbe152462
https://hg.mozilla.org/mozilla-central/rev/b01839e48205
https://hg.mozilla.org/mozilla-central/rev/fc9333c3b9f7