1850600 - suite pushes to comm-central run jobs unnecessarily

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

Looks like some recently added jobs don't have the right optimization set, so https://treeherder.mozilla.org/jobs?repo=comm-central&revision=82cc162e6567ccd0e40dd5f02f964889cfe3b7e0 ran a bunch of builds that should not have run.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1850600 - Set target_tasks_method to "nothing" for suite-only pushes. r=#thunderbird-build-system-reviewers

Relying on optimization strategies to keep suite-only pushes from running
builds unnecessarily mostly works, but not always. The optimization
strategy itself is fine, but if another strategy is used, like for the
source-test jobs, another strategy needs to be created that combines the
mozlint strategy with the no-suite strategy. It's a lot of maintenance.

Suite-only pushes should work like DONTBUILD pushes. The decision task runs
and literally nothing else. DONTBUILD pushes set target_tasks_method to
"nothing" to do that. Now, do the same for suite-only pushes by using
taskgraph's get_changed_files function. This should prove to be more robust
and future-proof.

Comment 2

[Rob Lemley [:rjl]]

With the above, the skip-suite-only optimization strategy and its derivatives can be removed which will make everything a lot easier.

The last thing would be to fix up jobs that have always-target set (lint checks mostly) and remove that attribute for suite-only pushes. That can be done pretty easily in a transform.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8dd67c6908c9
Set target_tasks_method to "nothing" for suite-only pushes. r=dandarnell