1850914 - update taskgraph test parameters

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Julien Cristau [:jcristau]]

Most of the files in taskcluster/test/params/ date back multiple years and don't quite reflect the current state.

Comment 1

[Julien Cristau [:jcristau]]

Attachment: Bug 1850914 - add script to update test parameters.yml. r=releng-reviewers,ahal,gabriel

If called with no arguments it'll update all files (except try.yml and
mr-onpush-geckoview.yml). It can also be called with a set of filenames
as arguments and will update just those files.

For on-push and cron tasks, we look up the taskcluster index for the
latest corresponding decision task. For release promotion actions, we
query the public shipit API to find the latest matching task.

Comment 2

[Julien Cristau [:jcristau]]

Attachment: Bug 1850914 - update test taskgraph parameters. r=releng-reviewers,ahal

Comment 3

[Julien Cristau [:jcristau]]

Attachment: Bug 1850914 - exclude taskgraph test params from yamllint. r=ahal,releng-reviewers,bhearsum

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f98c7051fd98
add script to update test parameters.yml. r=releng-reviewers,ahal,gabriel
https://hg.mozilla.org/integration/autoland/rev/fb5aa25d1c68
exclude taskgraph test params from yamllint. r=ahal,releng-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/193078fd7666
update test taskgraph parameters. r=releng-reviewers,ahal

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for lint failures on test/params/

Backout link: https://hg.mozilla.org/integration/autoland/rev/2097061651e27f28e441256c282f6e85da3d5b64
Log link: https://treeherder.mozilla.org/logviewer?job_id=432664139&repo=autoland&lineNumber=234

Comment 6

[Julien Cristau [:jcristau]]

It turns out exclude in tools/lint/yaml.yml doesn't work, and the way to go seems to be to add an ignore pattern in taskcluster/.yamllint instead.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5416d6faa8a4
add script to update test parameters.yml. r=releng-reviewers,ahal,gabriel
https://hg.mozilla.org/integration/autoland/rev/63b45ce2441e
exclude taskgraph test params from yamllint. r=ahal,releng-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/1bddb80abb57
update test taskgraph parameters. r=releng-reviewers,ahal

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing python failure on test_generate_params.py

Backout link

Push with failures

Failure log

Comment 9

[Julien Cristau [:jcristau]]

There's some unfortunate interaction with bug 1844592 here :/
The current test parameters don't set enable_always_target, so we use the defaults (true). The update means we pick up enable_always_target: false from e.g. esr115 graphs, and docker-image-index-task disappears from the target graph.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jcristau, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 11

[Julien Cristau [:jcristau]]

Attachment: Bug 1850914 - avoid checking for existing tc indexes when running test_generate_params on CI. r?#releng

The target_tasks methods for ship_geckoview and nightly_desktop return
an empty graph when running on automation if they detect a taskcluster
index from a previous run on the same revision. This wasn't a problem
with old parameters since the corresponding indexed tasks are expired,
but with updated parameters it starts triggering. We don't want that
logic here, since we're asserting we get a nonempty graph.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02bdacaadcbb
add script to update test parameters.yml. r=releng-reviewers,ahal,gabriel
https://hg.mozilla.org/integration/autoland/rev/c8442739bed9
avoid checking for existing tc indexes when running test_generate_params on CI. r=releng-reviewers,gbrown
https://hg.mozilla.org/integration/autoland/rev/dc342bf25278
exclude taskgraph test params from yamllint. r=ahal,releng-reviewers,bhearsum
https://hg.mozilla.org/integration/autoland/rev/7c5262c74b5c
update test taskgraph parameters. r=releng-reviewers,ahal

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/02bdacaadcbb
https://hg.mozilla.org/mozilla-central/rev/c8442739bed9
https://hg.mozilla.org/mozilla-central/rev/dc342bf25278
https://hg.mozilla.org/mozilla-central/rev/7c5262c74b5c