Closed Bug 1851018 Opened 2 years ago Closed 7 months ago

[meta] Respond to the "account state" push notifications

Categories

(Firefox for Android :: Accounts and Sync, enhancement)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
145 Branch
Tracking Status
firefox145 --- fixed

People

(Reporter: markh, Assigned: bdk)

References

(Depends on 1 open bug)

Details

(Keywords: meta, Whiteboard: [fxsync-])

Attachments

(2 files)

Steps to reproduce

  1. Have Fenix connected to an account
  2. On another device change the password/reset the password/delete the account/change profile info, etc

Expected behavior

  • Fenix immediately notices the account state change/profile change/etc

Actual behavior

  • Fenix waits until some time in the future (ie, whenever it ends up seeing a 401 from a server)

Best I can tell, everything is wired up for this to work (eg, there's an AccountAuthStateChanged event defined here which looks like gets correctly triggered by the app-services fxa-client component) but I don't see anything which handles them.

Whiteboard: [fxsync-]
Depends on: 1857028
Summary: Respond to the "account state" push notifications → [meta] Respond to the "account state" push notifications
Severity: -- → S3
Assignee: nobody → bdeankawamura
Status: NEW → ASSIGNED

Jon helped me get push notifications working on my emulator and it looks like this was working. After I change the password on my desktop device, I see this in the logs:

10-03 13:26:02.196  7923  8059 I FxA AccountStateEventsObserver: Saw AccountAuthStateChanged
10-03 13:26:02.196  7923  8059 I FxaDeviceConstellation: Successfully executed: processing raw commands
10-03 13:26:02.196  7923  8168 D FirefoxAccountStateMachine: processQueue: event: 'AuthenticationError - AccountAuthStateChanged event'
10-03 13:26:02.197  7923  8168 D FirefoxAccountStateMachine: processQueue: fxaEvent 'mozilla.appservices.fxaclient.FxaEvent$CheckAuthorizationStatus@f91205c'
10-03 13:26:02.197  7923  8168 I fxa_client::state_machine: breadcrumb: FxaStateMachine.process_event starting: CheckAuthorizationStatus
10-03 13:26:02.324  7923  8168 I fxa_client::state_machine: breadcrumb: FxaStateMachine.process_event CheckAuthorizationStatusSuccess -> Complete(AthIssues)
10-03 13:26:02.324  7923  8168 I fxa_client::state_machine: breadcrumb: FxaStateMachine.process_event finished (Complete(AthIssues))
10-03 13:26:02.325  7923  8168 D FirefoxAccountStateMachine: processQueue: new FxaState 'mozilla.appservices.fxaclient.FxaState$AuthIssues@611b43a'

... and when I open the menu, I see the following screenshot:

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: