1851038 - Make sure to release adb reverse ports after test is done

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

(In reply to Valentin Gosu [:valentin] (he/him) from comment bug 1411358 comment 618)

We do clean up in the code I linked above, but while looking into this I found 1, 2 places that don't clean up after themselves.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1851038 - Use NodeHTTPServer in test_http_server_timing.js instead of reimplementing it r=#necko

It became apparent that the custom NodeServer handler in
test_http_server_timing.js wasn't releasing forwarded adb ports.
Since NodeHTTPServer already does this correctly, we should use NodeHTTPServer
in test_http_server_timing.js instead of reimplementing this functionality.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1851038 - Make TRRServer extend NodeHTTP2Server r=#necko

It became apparent that TRRServer was forwarding adb ports but not releasing
them at the end of the test, possibly leading to port exhaustion when running
Android tests.
Since NodeHTTP2Server already implements this correctly, it makes sense to
simply make TRRServer extend NodeHTTP2Server and just implement the bits that
are different.

Depends on D187259

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8d16cfb08cb
Use NodeHTTPServer in test_http_server_timing.js instead of reimplementing it r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/6cd04b17df61
Make TRRServer extend NodeHTTP2Server r=necko-reviewers,kershaw

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f8d16cfb08cb
https://hg.mozilla.org/mozilla-central/rev/6cd04b17df61