1851089 - IndexError: list index out of range

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Under some circumstances, configure can fail with:

[task 2023-09-01T02:43:41.079Z] 02:43:41    ERROR -  Traceback (most recent call last):
[task 2023-09-01T02:43:41.079Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 329, in <module>
[task 2023-09-01T02:43:41.079Z] 02:43:41     INFO -      sys.exit(main(sys.argv))
[task 2023-09-01T02:43:41.079Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 126, in main
[task 2023-09-01T02:43:41.079Z] 02:43:41     INFO -      sandbox.run(os.path.join(os.path.dirname(__file__), "moz.configure"))
[task 2023-09-01T02:43:41.079Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 569, in run
[task 2023-09-01T02:43:41.079Z] 02:43:41     INFO -      func(*args)
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 620, in _value_for
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -      return self._value_for_depends(obj)
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 1063, in method_call
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -      cache[args] = self.func(instance, *args)
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 629, in _value_for_depends
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -      value = obj.result()
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 1063, in method_call
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -      cache[args] = self.func(instance, *args)
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 161, in result
[task 2023-09-01T02:43:41.080Z] 02:43:41     INFO -      return self._func(*resolved_args)
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 1313, in wrapped
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -      return new_func(*args, **kwargs)
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 912, in wrapper
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -      ret = template(*args, **kwargs)
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/build/moz.configure/checks.configure", line 59, in wrapped
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -      ret = func(*args, **kwargs)
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 1313, in wrapped
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -      return new_func(*args, **kwargs)
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/toolkit/moz.configure", line 1586, in has_pack_relative_relocs
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -      needed = [l for l in dyn if l.split()[1] == "(NEEDED)"]
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -    File "/builds/worker/checkouts/gecko/toolkit/moz.configure", line 1586, in <listcomp>
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -      needed = [l for l in dyn if l.split()[1] == "(NEEDED)"]
[task 2023-09-01T02:43:41.081Z] 02:43:41     INFO -  IndexError: list index out of range

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1851089 - Avoid failing to parse readelf output.

Some lines may have less than 2 fields (mostly, empty lines).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1847697

Comment 3

[Intermittent Failures Robot]

1 failures in 3019 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• android-hw-a51-11-0-aarch64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1851089&startday=2023-08-28&endday=2023-09-03&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bebcd3dd6b66
Avoid failing to parse readelf output. r=firefox-build-system-reviewers,sergesanspaille

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bebcd3dd6b66

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 9351148 [details]
Bug 1851089 - Avoid failing to parse readelf output.

Beta/Release Uplift Approval Request

• User impact if declined: Failure to build Firefox under some circumstances
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB
• String changes made/needed: N/A
• Is Android affected?: No

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9351148 [details]
Bug 1851089 - Avoid failing to parse readelf output.

Approved for 118.0b6, thanks.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fbb85998ef28

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/fbb85998ef28